Fixes for issues #39 and #40 #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing idempotency of postmap's task, replacing a Jinja templating test (which runs on controller machine only) by an extra stat task. * Skiping assertion when running in check_mode (to allow to run this role in test mode).
In some circunstances, this role fails to run these tasks: * Check if a hash of a text-based database is missing * Run postmap(1) to recreate a missing hash database With this change it'll run these tasks only when it is really needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing idempotency of postmap's task, replacing a Jinja templating
test (which runs on controller machine only) by an extra stat task. (Idempotency issue on postmap task #40)
Skiping assertion when running in check_mode (to allow to run this
role in test mode)(Task failing when running on check mode #39).