Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of Swift Playground at CommentSpacingRule.swift #5691

Merged

Conversation

lamtrinhdev
Copy link
Contributor

Correct typo of Swift Playground at CommentSpacingRule.swift , it appears in production at https://realm.github.io/SwiftLint/comment_spacing.html .

Correct typo for Swift Playground.
@lamtrinhdev lamtrinhdev changed the title Update CommentSpacingRule.swift Fix typo of Swift Playground at CommentSpacingRule.swift Jul 24, 2024
@SwiftLintBot
Copy link

SwiftLintBot commented Jul 24, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.25s vs 0.23s on main (8% slower)
📖 Linting Alamofire with this PR took 0.27s vs 0.27s on main (0% slower)
📖 Linting Brave with this PR took 1.32s vs 1.31s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 0.77s vs 0.77s on main (0% slower)
📖 Linting Firefox with this PR took 2.13s vs 2.13s on main (0% slower)
📖 Linting Kickstarter with this PR took 1.46s vs 1.48s on main (1% faster)
📖 Linting Moya with this PR took 0.15s vs 0.15s on main (0% slower)
📖 Linting NetNewsWire with this PR took 0.51s vs 0.5s on main (2% slower)
📖 Linting Nimble with this PR took 0.18s vs 0.18s on main (0% slower)
📖 Linting PocketCasts with this PR took 1.3s vs 1.27s on main (2% slower)
📖 Linting Quick with this PR took 0.13s vs 0.13s on main (0% slower)
📖 Linting Realm with this PR took 0.86s vs 0.86s on main (0% slower)
📖 Linting Sourcery with this PR took 0.46s vs 0.48s on main (4% faster)
📖 Linting Swift with this PR took 0.81s vs 0.81s on main (0% slower)
📖 Linting VLC with this PR took 0.3s vs 0.3s on main (0% slower)
📖 Linting Wire with this PR took 3.24s vs 3.25s on main (0% faster)
📖 Linting WordPress with this PR took 2.15s vs 2.14s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Fix typo of Swift Playground at CommentSpacingRule.swift.  
  [lamtrinhdev](https://github.com/lamtrinhdev)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lamtrinhdev
Copy link
Contributor Author

Dear @SimplyDanny ,

We have some failing cases. Could you help me to check it?

Thanks,
Lam

@alex-taffe
Copy link

It seems like the main branch is currently broken for what that's worth

@mildm8nnered
Copy link
Collaborator

It seems like the main branch is currently broken for what that's worth

I see it - just putting up a PR to fix that - @SimplyDanny

@mildm8nnered
Copy link
Collaborator

mildm8nnered commented Jul 24, 2024

PR at #5695, which seems to failing :-(

@lamtrinhdev
Copy link
Contributor Author

lamtrinhdev commented Jul 24, 2024

How can the PR #5694 build successful for 12 tasks?

@SimplyDanny
Copy link
Collaborator

SimplyDanny commented Jul 24, 2024

How can the PR #5694 build successful for 12 tasks?

It is based on b9f3843 which is the commit before the compile issues were introduced.

PR at #5695, which seems to failing :-(

It only failed OSS check. That's because OSS check does not only build the PR branch but also main (which still had the issues).

I just merged it and so main should be good again now.

@mildm8nnered: Thank you for the fix!
@lamtrinhdev: Please rebase your PR onto main. Build ought to be successful again.

@alex-taffe
Copy link

Yeah I intentionally rewound mine by 1 commit

@lamtrinhdev
Copy link
Contributor Author

Thank you for your support, @mildm8nnered , @SimplyDanny , @alex-taffe . Let me update to date my branch.

@SimplyDanny
Copy link
Collaborator

You should rebase your branch instead of merging main into it. Danger doesn't like merges. 😉

@lamtrinhdev
Copy link
Contributor Author

I got it. Thank you for your support @SimplyDanny .

@SimplyDanny SimplyDanny enabled auto-merge (squash) July 24, 2024 18:19
@SimplyDanny SimplyDanny merged commit 03b28d5 into realm:main Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants