-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo of Swift Playground at CommentSpacingRule.swift #5691
Fix typo of Swift Playground at CommentSpacingRule.swift #5691
Conversation
Correct typo for Swift Playground.
Here's an example of your CHANGELOG entry: * Fix typo of Swift Playground at CommentSpacingRule.swift.
[lamtrinhdev](https://github.com/lamtrinhdev)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number) note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Dear @SimplyDanny , We have some failing cases. Could you help me to check it? Thanks, |
It seems like the main branch is currently broken for what that's worth |
I see it - just putting up a PR to fix that - @SimplyDanny |
PR at #5695, which seems to failing :-( |
How can the PR #5694 build successful for 12 tasks? |
It is based on b9f3843 which is the commit before the compile issues were introduced.
It only failed OSS check. That's because OSS check does not only build the PR branch but also I just merged it and so @mildm8nnered: Thank you for the fix! |
Yeah I intentionally rewound mine by 1 commit |
Thank you for your support, @mildm8nnered , @SimplyDanny , @alex-taffe . Let me update to date my branch. |
You should rebase your branch instead of merging |
Correct typo for Swift Playground.
…b.com/lamtrinhdev/SwiftLint into Correct_Typo_CommentSpacingRule.swift
I got it. Thank you for your support @SimplyDanny . |
Correct typo of Swift Playground at CommentSpacingRule.swift , it appears in production at https://realm.github.io/SwiftLint/comment_spacing.html .