tsan fixes #6930
Merged
tsan fixes #6930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiburtse
approved these changes
Aug 28, 2023
kiburtse
merged commit a69c48d
into
kb/sanitizer_build_configs_improve
1 of 2 checks passed
kiburtse
pushed a commit
that referenced
this pull request
Aug 30, 2023
* maybe fix a buffer overrun in a test * maybe fix a race in async_open_realm test util
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to get TSAN to report the errors locally so this is a best guess as to what the problem could be. I'll let CI verify.
I think the first problem was that the test
Json_Timestampwas using an insufficient buffer size. I changed the size to be part of the type so that an incorrect size is a compiler error.The thread issue about using Catch macros on a different thread I think I have solved by invoking the finish callback from our
async_open_realmtest utility on the calling thread.