Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to manually consume space if posix_fallocate isn't supported at runtime #7251

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fallback to manually consume space if posix_fallocate isn't supported at runtime #7251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db9e0b
fallback to manually consume space if posix_fallocate isn't supported…
ironage Jan 11, 2024
3969219
Merge branch 'master' into js/fallocate-fallback
ironage Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* None.

### Fixed
* Handle `EOPNOTSUPP` when using `posix_fallocate()` and fallback to manually consume space. This should enable android users to open a Realm on restrictive filesystems. ([realm-js #6349](https://github.com/realm/realm-js/issues/6349), more prevalent since v13.23.3 with the change to `REALM_HAVE_POSIX_FALLOCATE` but it was also an issue in some platforms before this)
* Application may crash with `incoming_changesets.size() != 0` when a download message is mistaken for a bootstrap message (PR [#7238](https://github.com/realm/realm-core/pull/7238), since v11.8.0)

### Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion src/realm/util/file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ bool File::prealloc_if_supported(SizeType offset, size_t size)
return true;
}

if (status == EINVAL || status == EPERM) {
if (status == EINVAL || status == EPERM || status == EOPNOTSUPP) {
return false; // Retry with non-atomic version
}

Expand Down