RCORE-2162: Add compression of strings in Mixed, Lst<String> and Dictionary #7804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nicola-cab
reviewed
Jun 13, 2024
jedelbo
force-pushed
the
je/string-interning
branch
2 times, most recently
from
eef0397
to
af8c988
Compare
jedelbo
force-pushed
the
je/string-interning
branch
from
af8c988
to
c53ea27
Compare
|
@ironage please have a look at the modified client reset test. I think there is a problem as the 'after' callback is not synchonized with the main thread so we can't be sure that the callback has happened before the check is done. This has happened many times in ASAN runs. Do you think there is a better solution than the current fix? |
Pull Request Test Coverage Report for Build jorgen.edelbo_308Details
💛 - Coveralls |
jedelbo
force-pushed
the
je/string-interning
branch
from
e0bba68
to
07fde03
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_311Details
💛 - Coveralls |
nicola-cab
approved these changes
Jun 18, 2024
src/realm/array_mixed.hpp
Outdated
| @@ -135,6 +144,7 @@ class ArrayMixed : public ArrayPayload, private Array { | |||
| mutable ArrayString m_strings; | |||
| // Used to store nested collection refs | |||
| mutable ArrayRef m_refs; | |||
| mutable StringInterner* m_string_interner = nullptr; | |||
There was a problem hiding this comment.
Why do you need to cache the StringInterner? Shouldn't m_strings have the interner set?
There was a problem hiding this comment.
You are right. That should work.
| @@ -1168,6 +1173,35 @@ REALM_FORCEINLINE void Obj::sync(Node& arr) | |||
| } | |||
| } | |||
|
|
|||
| // helper functions for filtering out calls to set_string_interner() | |||
| template <class T> | |||
| inline void Obj::set_string_interner(T&, ColKey) | |||
There was a problem hiding this comment.
I think values.set_string_interner(m_table->get_string_interner(col_key)); can just go in the main template method. The interface is basically the same, isn't it?
There was a problem hiding this comment.
It is an optimization to only call that method for strings and mixed.
src/realm/table.cpp
Outdated
| if (data_ref) | ||
| Array::destroy_deep(data_ref, m_alloc); | ||
| m_interner_data.set(col_ndx, 0); | ||
| // m_string_interners[col_ndx]->update_from_parent(true); |
| @@ -1048,6 +1048,13 @@ TEST_CASE("sync: client reset", "[sync][pbs][client reset][baas]") { | |||
| }, | |||
| std::chrono::seconds(20), std::chrono::milliseconds(500)); | |||
| } | |||
| // We can't be sure that the 'after' callback has been called yet | |||
| timed_sleeping_wait_for( | |||
There was a problem hiding this comment.
Why isn't the wait at line 1049 enough? Maybe we should extend std::chrono::milliseconds(500) to whatever it is needed.
There was a problem hiding this comment.
Ok - I thought I removed the 500 ms addition in line 1049. The 500 ms is just the time we sleep between each time we check the condition. If the condition is true, we will return immediately.
jedelbo
force-pushed
the
je/string-interning
branch
from
c4602d9
to
8f3f487
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_316Details
💛 - Coveralls |
jedelbo
force-pushed
the
je/string-interning
branch
from
8f3f487
to
2c8d86e
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_317Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed