Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2153: Fix issue when clearing a Lst<Mixed> in an upgraded file #7806

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Jun 12, 2024

What, How & Why?

Fixes #7771

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Jun 12, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_295

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 58 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.95%

Files with Coverage Reduction New Missed Lines %
src/realm/dictionary.cpp 1 85.13%
test/test_util_network.cpp 1 95.56%
src/realm/query_expression.hpp 2 93.81%
test/test_lang_bind_helper.cpp 2 93.2%
src/realm/parser/driver.cpp 3 87.57%
src/realm/sync/client.cpp 3 91.78%
src/realm/sync/instruction_replication.cpp 3 91.48%
test/fuzz_group.cpp 3 48.8%
src/realm/link_translator.cpp 4 76.92%
src/realm/bplustree.cpp 6 72.55%
Totals Coverage Status
Change from base Build 2408: -0.01%
Covered Lines: 214675
Relevant Lines: 236035

💛 - Coveralls

Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix seems fine. Please add a test, hopefully we have a list of mixed in one of the file upgrade tests you can use?

@jedelbo
Copy link
Contributor Author

jedelbo commented Jun 13, 2024

Unfortunately there is not any lists in the upgrade files. I will consider making a file with all our types so we can use that in future cases like this. But I will not do it in this context. I did verify, however, that we would hit this issue on an upgraded file.

@jedelbo jedelbo merged commit b576cbc into master Jun 13, 2024
4 of 5 checks passed
@jedelbo jedelbo deleted the je/RCORE-2153 branch June 13, 2024 07:52
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[realm-core-14.7.0] Assertion failed: ndx < m_size [4, 4]
2 participants