Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2168: Replicate clear instruction unconditionally #7810

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Jun 13, 2024

What, How & Why?

Fixes #7809

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Jun 14, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_302

Details

  • 63 of 63 (100.0%) changed or added relevant lines in 4 files are covered.
  • 220 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.97%

Files with Coverage Reduction New Missed Lines %
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/noinst/client_impl_base.cpp 1 82.57%
src/realm/util/serializer.cpp 1 90.74%
test/test_dictionary.cpp 1 99.83%
src/realm/array_blobs_big.cpp 2 98.58%
src/realm/cluster.cpp 2 75.6%
src/realm/db.cpp 2 92.05%
src/realm/sync/network/http.hpp 2 82.27%
test/object-store/util/test_file.cpp 2 86.29%
test/test_sync.cpp 2 92.98%
Totals Coverage Status
Change from base Build 2418: -0.002%
Covered Lines: 214771
Relevant Lines: 236091

💛 - Coveralls

@dianaafanador3
Copy link
Contributor

@jedelbo this is not clearing the list when assigning to a mixed list, which instead is using Lst<Mixed>::clear().in list.cpp

@danieltabacaru
Copy link
Collaborator

danieltabacaru commented Jun 18, 2024

@jedelbo this is not clearing the list when assigning to a mixed list, which instead is using Lst<Mixed>::clear().in list.cpp

right. all list types should make the change. @jedelbo Please also add a test for List<Mixed>.

@dianaafanador3 dianaafanador3 self-requested a review June 18, 2024 11:00
@jedelbo
Copy link
Contributor Author

jedelbo commented Jun 18, 2024

Thanks @dianaafanador3 .

Copy link

coveralls-official bot commented Jun 18, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_314

Details

  • 78 of 78 (100.0%) changed or added relevant lines in 5 files are covered.
  • 184 unchanged lines in 23 files lost coverage.
  • Overall coverage increased (+0.005%) to 90.976%

Files with Coverage Reduction New Missed Lines %
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/noinst/server/server.cpp 1 73.78%
src/realm/util/serializer.cpp 1 90.43%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
test/test_query2.cpp 1 98.73%
test/test_table.cpp 1 99.51%
test/test_util_network.cpp 1 95.56%
src/realm/object-store/shared_realm.cpp 2 91.89%
test/object-store/util/test_file.cpp 2 86.29%
Totals Coverage Status
Change from base Build 2426: 0.005%
Covered Lines: 214803
Relevant Lines: 236109

💛 - Coveralls

@jedelbo jedelbo merged commit b5ca450 into master Jun 18, 2024
39 checks passed
@jedelbo jedelbo deleted the je/replicate-clear branch June 18, 2024 12:02
jedelbo added a commit that referenced this pull request Jun 18, 2024
jedelbo added a commit that referenced this pull request Jun 19, 2024
…" (#7819)

This reverts commit b5ca450.

Co-authored-by: Jørgen Edelbo <jorgen.edelbo@mongodb.com>
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning a mixed property with a collection should replace instead of merge
3 participants