Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2264: Skip backup files when scanning for audit Realms to upload #8038

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Oct 8, 2024

Backup realms from file format upgrades are placed next to the original file, so the audit realm pool will find the backup and attempt to upload it, triggering another upgrade and backup until the filename becomes too long and it crashes instead. It needs to instead skip the backup files and delete any lingering backups of Realms which have already been uploaded.

Fixes #8040

Backup realms from file format upgrades are placed next to the original file,
so the audit realm pool will find the backup and attempt to upload it,
triggering another upgrade and backup until the filename becomes too long and
it crashes instead. It needs to instead skip the backup files and delete any
lingering backups of Realms which have already been uploaded.
@tgoyne tgoyne added the no-jira-ticket Skip checking the PR title for Jira reference label Oct 8, 2024
@tgoyne tgoyne self-assigned this Oct 8, 2024
@cla-bot cla-bot bot added the cla: yes label Oct 8, 2024
Copy link

Pull Request Test Coverage Report for Build thomas.goyne_526

Details

  • 38 of 43 (88.37%) changed or added relevant lines in 3 files are covered.
  • 68 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/object-store/audit.mm 26 31 83.87%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/network/websocket.cpp 1 72.2%
src/realm/sync/noinst/server/server_history.cpp 1 62.92%
src/realm/sync/transform.cpp 3 61.01%
test/fuzz_group.cpp 3 47.05%
src/realm/table.cpp 4 90.42%
src/realm/sync/noinst/server/server.cpp 6 74.17%
src/realm/index_string.cpp 8 84.85%
src/realm/sync/instruction_applier.cpp 15 68.01%
src/realm/object-store/audit.mm 27 90.98%
Totals Coverage Status
Change from base Build 2615: 0.007%
Covered Lines: 217220
Relevant Lines: 238400

💛 - Coveralls

@tgoyne tgoyne requested a review from jedelbo October 9, 2024 01:50
@jedelbo jedelbo removed the no-jira-ticket Skip checking the PR title for Jira reference label Oct 9, 2024
@jedelbo jedelbo changed the title Skip backup files when scanning for audit Realms to upload RCORE-2264: Skip backup files when scanning for audit Realms to upload Oct 9, 2024
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgoyne tgoyne merged commit 978ca22 into master Oct 9, 2024
18 of 39 checks passed
@tgoyne tgoyne deleted the je/fix-backlink-notifications branch October 9, 2024 17:26
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent endless looping in event library after file version upgrade.
2 participants