Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax IndexOf conditions to handle null and unmanaged objects #3369

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jul 3, 2023

Description

Looks like MAUI really wants to use indexof and our validations are making it quite hard to data bind to realm collections directly. Not sure if this is the best approach here, but need something hacky for a demo.

TODO

  • Changelog entry
  • Tests (if applicable)

@coveralls
Copy link

coveralls commented Jul 3, 2023

Pull Request Test Coverage Report for Build 5486435754

  • 11 of 13 (84.62%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/DatabaseTypes/RealmList.cs 0 1 0.0%
Realm/Realm/DatabaseTypes/RealmSet.cs 3 4 75.0%
Totals Coverage Status
Change from base Build 5399781181: 0.02%
Covered Lines: 6172
Relevant Lines: 7362

💛 - Coveralls

@nirinchev nirinchev marked this pull request as ready for review July 7, 2023 12:33
@nirinchev nirinchev merged commit 9b29f1a into main Jul 7, 2023
78 of 79 checks passed
@nirinchev nirinchev deleted the ni/relax-indexof branch July 7, 2023 15:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants