Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose base file path and base uri on App #3385

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Expose base file path and base uri on App #3385

merged 4 commits into from
Jul 21, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jul 20, 2023 •
edited
Loading

Description

Alleviates a bit of the pain reported in #3383
Fixes #3382

Exposes App.BaseFilePath, App.BaseUri, and App.Id.

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Jul 20, 2023
@nirinchev nirinchev requested a review from papafe July 20, 2023 12:07
@nirinchev nirinchev mentioned this pull request Jul 20, 2023
Closed
@coveralls
Copy link

coveralls commented Jul 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5611912033

  • 54 of 54 (100.0%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 82.399%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Extensions/TaskExtensions.cs 1 68.09%
Realm/Realm/Handles/SubscriptionSetHandle.cs 3 95.41%
Totals Coverage Status
Change from base Build 5597705507: 0.2%
Covered Lines: 6183
Relevant Lines: 7363
💛 - Coveralls

@nirinchev nirinchev merged commit ab7d4b4 into main Jul 21, 2023
65 of 66 checks passed
@nirinchev nirinchev deleted the ni/app-properties branch July 21, 2023 09:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Apps in same Process wrongfully Activate each others' Users
3 participants
@nirinchev @coveralls @papafe