Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more extensive coverage for Task.Timeout #3388

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Conversation

nirinchev
Copy link
Member

Description

Noticed coverage was quite lacking there and while it's not particularly complex functionality, figured it's worth adding a simple test to ensure it works as intended.

@cla-bot cla-bot bot added the cla: yes label Jul 20, 2023
@nirinchev nirinchev added no-changelog Used to skip the changelog check and removed cla: yes labels Jul 20, 2023
@cla-bot cla-bot bot added the cla: yes label Jul 20, 2023
@coveralls
Copy link

coveralls commented Jul 20, 2023

Pull Request Test Coverage Report for Build 5621386565

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 82.759%

Files with Coverage Reduction New Missed Lines %
Realm/Realm/Sync/AppConfiguration.cs 1 92.59%
Realm/Realm/Sync/App.cs 19 73.86%
Totals Coverage Status
Change from base Build 5614974815: 0.1%
Covered Lines: 6168
Relevant Lines: 7317

💛 - Coveralls

@nirinchev nirinchev requested a review from papafe July 21, 2023 10:43
@nirinchev nirinchev merged commit f55dfd5 into main Jul 21, 2023
65 of 66 checks passed
@nirinchev nirinchev deleted the ni/task-timeout branch July 21, 2023 11:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants