Improvements related to Remote MongoDB access #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Nov 29, 2023
| using var realm = await GetRealmAsync(config); | ||
| await WaitForUploadAsync(realm); | ||
|
|
||
| var client = user.GetMongoClient(ServiceName); // TODO: this should be provided by Sync |
There was a problem hiding this comment.
No longer relevant - in scoping we decided to keep the service name argument
papafe
reviewed
Dec 12, 2023
| // Use sync to create the schema/rules | ||
| SyncConfigurationBase config = appConfigType == AppConfigType.FlexibleSync ? GetFLXIntegrationConfig(user) : GetIntegrationConfig(user); | ||
|
|
||
| config.Schema = GetTransitiveSchema(typeof(T), new()).Values.ToArray(); |
There was a problem hiding this comment.
How come we're trying to limit the schema here? Is it to improve the speed of the test?
# Conflicts: # .github/templates/build-packages.yml # .github/workflows/build-packages.yml # global.json
* Various fixes * Removed unused * Fixes to bsondocument equality * Passingn tests * Added embedded test * Added test for embedded * Added fix for not implemented * Fixed serializer and added correct serialization of realm value * Fixed tests for object in realm value * Fixed deserialization object in realm value * Moved method * Split collection class * Revert "Split collection class" This reverts commit eee2d42. * Added test to remove * Removed unused class and test * Separated serializer from serializer registry * Added basic tests for primitives * Added more tests * Added tests for links * Added several tests * Added tests for embedded * Removed unused param * Removed unnecessary * Various fixes * Added missing cases * Added docs and improved serialization * Added tests * Added saving of schema * Added correct handling of extra fields and changelog * Corrected exception check * Small fixes * Small corrections * Moved tests to a new fixture * Small correction * Reinstated reflection * Small fixes * Warning fix * Updated source generated test classes * Corrected weavers errors * Corrected platformhelper and testobject * Fixed source generator test * Added fix for ctor * Small fixes * Corrections to test
|
I've just merged my branch into this one. |
Pull Request Test Coverage Report for Build 7489097804
💛 - Coveralls |
|
@nirinchev As we discussed:
If the CI is green (or almost) this is mergeable |
|
@nirinchev The new release is out, so this is mergeable for me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is still WIP, but explores a SG-based approach for using RealmObject classes for remote mongodb access.
TODO