Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for expressions in keypath building #3518
Added support for expressions in keypath building #3518
Changes from 5 commits
03c48d7
4052fdc
8403227
0060595
48da015
378d099
0823a38
928291c
4c0f746
5f99655
afd96bb
637a3ea
8541a85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Verify TODOs
Realm/Realm/DatabaseTypes/KeyPathCollection.cs#L143
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (ubuntu-latest, linux-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (ubuntu-latest, linux-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (ubuntu-latest, linux-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Source Generation
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Package / NuGet
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Package / NuGet
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Analyze C#
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Analyze C#
Check warning on line 143 in Realm/Realm/DatabaseTypes/KeyPathCollection.cs
GitHub Actions / Test / Code Coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
For
name something from Swift/ObjC? I guess I understand where it's coming from, but it's also kind of unusual for a .NET API name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's something I thought made sense for this case 😁
I also thought it was following a similar "style" of
KeyPathCollection.Of
. Do you have any other name suggestion? I would much more prefer to have a static method than using the constructor to be honest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirinchev, do you have any suggestion here about an alternative name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be impossible to use the ctor here, because we need the generic arg. Perhaps it's a bit verbose, but how about
FromExpression
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it sounds reasonable :)
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.