Fix various failing CI tests #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papafe
commented
Feb 23, 2024
| @@ -1328,7 +1328,7 @@ public void Session_WaitForUpload_CanBeCancelled() | |||
|
|
|||
| sw.Stop(); | |||
|
|
|||
| Assert.That(sw.ElapsedMilliseconds, Is.LessThan(5)); | |||
There was a problem hiding this comment.
Even locally these two tests didn't pass all the time
papafe
commented
Feb 23, 2024
| @@ -1257,7 +1257,7 @@ private async Task<MongoClient.Collection<T>> GetCollection<T>(string appConfigT | |||
|
|
|||
| SyncConfigurationBase config = appConfigType == AppConfigType.FlexibleSync ? GetFLXIntegrationConfig(user) : GetIntegrationConfig(user); | |||
|
|
|||
| using var realm = await GetRealmAsync(config); | |||
| using var realm = await GetRealmAsync(config, true); | |||
There was a problem hiding this comment.
We need to wait for the schema to be synchronized, otherwise the call to the backends without the database name could raise an exception
papafe
commented
Feb 23, 2024
| // Unsubscribe and verify that it no longer raises user changed | ||
| user.Changed -= OnUserChanged; | ||
|
|
||
| tcs = new(); |
There was a problem hiding this comment.
Sometimes no TimeoutException was raised at the end of the method on CI. I verified that actually we get two Changed notifications, one for the custom data, and one for the user token refresh.
I suspect that sometimes the second notification was being raised after the new token completion source was created but before the unsubscription, that's why the timeout had no effect.
nirinchev
approved these changes
Feb 23, 2024
Pull Request Test Coverage Report for Build 8021119280Details
💛 - Coveralls |
nirinchev
added a commit
that referenced
this pull request
Feb 27, 2024
* main: Fix various failing CI tests (#3535)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3526