Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Create a local-only realm package #3660

Merged
merged 18 commits into from
Sep 9, 2024
Merged

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Aug 19, 2024

CI failure reasons:

Platform Reason
Maui - iOS An issue with booting the simulator on macos-14 runners
UWP Certificate expired
Unity Certificate server issues

Metrics:

Project LoC (old) LoC (new) Executable LoC (old) Executable LoC (new)
Realm 15,463 7,934 (-49%) 6,414 4,888 (-24%)
Realm.Tests 115,009 95,004 (-18%) 36,449 29,211 (-19%)

Binary sizes:

Platform Size (old) Size (new) Change
wrappers-android-arm64-v8a 5.04 MB 3.8 MB -25%
wrappers-android-armeabi-v7a 3.65 MB 2.6 MB -29%
wrappers-android-x86 4.82 MB 3.52 MB -27%
wrappers-android-x86_64 4.74 MB 3.5 MB -26%
wrappers-catalyst 21.1 MB 14.4 MB -32%
wrappers-iOS-Device 4.67 MB 3.07 MB -34%
wrappers-iOS-Simulator 9.89 MB 6.53 MB -34%
wrappers-linux-aarch64 5.92 MB 4.52 MB -24%
wrappers-linux-armhf 5.32 MB 3.88 MB -27%
wrappers-linux-x86_64 5.86 MB 4.35 MB -26%
wrappers-macos 5.39 MB 3.67 MB -32%
wrappers-tvOS-Device 4.66 MB 3.06 MB -34%
wrappers-tvOS-Simulator 9.88 MB 6.52 MB -34%
wrappers-windows-ARM64 13.5 MB 5.33 MB -61%
wrappers-windows-Win32 13.1 MB 5.26 MB -60%
wrappers-windows-uwp-ARM 11.3 MB 4.15 MB -63%
wrappers-windows-uwp-ARM64 11.5 MB 4.34 MB -62%
wrappers-windows-uwp-Win32 11.4 MB 4.11 MB -64%
wrappers-windows-uwp-x64 11.8 MB 4.31 MB -63%
wrappers-windows-x64 14.7 MB 5.47 MB -63%

@nirinchev nirinchev added no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference labels Aug 19, 2024
@@ -304,7 +304,7 @@
var type = typeof(TValue);
Action<BsonSerializationContext, BsonSerializationArgs, object?> serialize = type switch
{
_ when type.IsRealmObject() || type.IsAsymmetricObject() => RealmObjectSerializer.LookupSerializer(type)!.SerializeId,
_ when type.IsRealmObject() => RealmObjectSerializer.LookupSerializer(type)!.SerializeId,

Check warning

Code scanning / CodeQL

Constant condition Warning

Pattern always matches.
@@ -325,7 +325,7 @@
var type = typeof(TValue);
Action<BsonSerializationContext, BsonSerializationArgs, object?> serialize = type switch
{
_ when type.IsRealmObject() || type.IsAsymmetricObject() => RealmObjectSerializer.LookupSerializer(type)!.SerializeId,
_ when type.IsRealmObject() => RealmObjectSerializer.LookupSerializer(type)!.SerializeId,

Check warning

Code scanning / CodeQL

Constant condition Warning

Pattern always matches.
@nirinchev nirinchev changed the base branch from main to community September 9, 2024 12:48
@nirinchev nirinchev marked this pull request as ready for review September 9, 2024 14:20
@nirinchev nirinchev merged commit 384b9f2 into community Sep 9, 2024
51 of 52 checks passed
@nirinchev nirinchev deleted the ni/local-realm branch September 9, 2024 14:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant