Update to latest core #7837
Merged
Update to latest core #7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
commented
Jul 31, 2023
| @@ -51,10 +50,6 @@ public static OsAppCredentials apiKey(String key) { | |||
| return new OsAppCredentials(nativeCreate(TYPE_API_KEY, key)); | |||
| } | |||
|
|
|||
| public static OsAppCredentials serverApiKey(String key) { | |||
There was a problem hiding this comment.
This wasn't really used and not exposed in the SDK. Removed from core in realm/realm-core#5914
cmelchior
approved these changes
Jul 31, 2023
Update sync error codes and deprecate old ones.
# Conflicts: # CHANGELOG.md
added 2 commits
October 2, 2023 15:57
|
Ready for review |
nhachicha
reviewed
Oct 6, 2023
realm/realm-library/src/androidTest/java/io/realm/LinkingObjectsQueryTests.java
Outdated
Show resolved
Hide resolved
| @@ -401,11 +400,11 @@ public void isEmpty_acrossLink() { | |||
| case LINKING_OBJECTS: | |||
| // Rows 0 and 1 are not included as they are linked to another row through FIELD_OBJECT | |||
| // Row 2 is included (no link) | |||
| assertEquals(1, realm.where(AllJavaTypesUnsupportedTypes.class).isEmpty(AllJavaTypesUnsupportedTypes.FIELD_OBJECT + "." + AllJavaTypesUnsupportedTypes.FIELD_LO_OBJECT).count()); | |||
There was a problem hiding this comment.
Why the expected values changed for these tests?
There was a problem hiding this comment.
It was changed after realm/realm-core#6867. There was a lot of discussion about this, but in the end, we determined that the old behavior was buggy and subsequently fixed.
| java_error_message = JavaLocalRef<jstring>(env, env->NewStringUTF( | ||
| status.reason().c_str())); | ||
| java_error_code = JavaLocalRef<jobject>(env, JavaClassGlobalDef::new_long(env, static_cast<int32_t>(status.code()))); | ||
| java_error_message = JavaLocalRef<jstring>(env, env->NewStringUTF( status.reason().c_str())); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7775