Update build workflow and remove unused scripts #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/build-workflow
branch
from
3af5827 to
ae366ce
Compare
kraenhansen
commented
Feb 28, 2024
| - name: Install wine | ||
| run: | | ||
| sudo dpkg --add-architecture i386 | ||
| sudo apt-get update | ||
| sudo apt install -y wine wine32 | ||
| - name: Install dependencies | ||
| run: npm ci --legacy-peer-deps |
There was a problem hiding this comment.
Seems this isn't necessary after all.
kraenhansen
commented
Feb 28, 2024
| @@ -28,14 +34,14 @@ jobs: | |||
| - name: Setup Node | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 20 | |||
| node-version: 18 | |||
There was a problem hiding this comment.
Aligning with the version used by the Electron dependency.
kneth
approved these changes
Feb 28, 2024
| npx electron-builder -lw --publish never --dir --x64 | ||
| # Copying over the app-update.yml from Linux as it is skipped when using --dir | ||
| # https://github.com/electron-userland/electron-builder/blob/79df54238621fbe48ba20444129950ba2dc49983/packages/app-builder-lib/src/publish/PublishManager.ts#L113-L115 | ||
| cat dist/linux-unpacked/resources/app-update.yml |
There was a problem hiding this comment.
Not strictly needed, but I wanted to be sure it exists (as it's relying on undocumented behaviour of electron-builder) and displaying its contents might help debugging future issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the build workflow with a couple of fixes to issues discovered while publishing and removes scripts that are no longer used as we've transitioned to GitHub actions.