RSTUDIO-540: Fix connect to server #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Jun 20, 2024
Comment on lines
+38
to
+39
| const DEFAULT_BASE_URL = 'https://services.cloud.mongodb.com'; | ||
| const LEGACY_BASE_URL = 'https://realm.mongodb.com'; |
There was a problem hiding this comment.
I went ahead and updated the base URL in the PR as well.
kraenhansen
commented
Jun 20, 2024
| @@ -169,6 +170,7 @@ export abstract class RealmLoadingComponent< | |||
| } | |||
| }, | |||
| }, | |||
| */ | |||
There was a problem hiding this comment.
Disabling the initial subscription, since this could potentially result in a huge download that we don't want to wait for.
kraenhansen
commented
Jun 20, 2024
| @@ -114,9 +115,8 @@ class ConnectToServerContainer extends React.Component< | |||
| const { appId, url } = this.state; | |||
| // Use SDK default (passing undefined) on an empty string. | |||
| const baseUrl = url || DEFAULT_BASE_URL; | |||
| // Clear test state to invalidate the shared App cache as a work around for | |||
| // TODO: Clear test state to invalidate the shared App cache as a work around for | |||
There was a problem hiding this comment.
From my testing, I'm unable to reproduce this and it seems fair to disable the workaround for now. I'm leaving the comment for a future where this resurfaces.
kraenhansen
commented
Jun 20, 2024
| @@ -156,11 +156,12 @@ export abstract class RealmLoadingComponent< | |||
| }); | |||
| const credentials = hydrateCredentials(realm.credentials); | |||
| const user = await app.logIn(credentials); | |||
| return new Realm({ | |||
| return Realm.open({ | |||
There was a problem hiding this comment.
Using Realm.open here to ensure the schema gets downloaded before the Realm is considered loaded.
gagik
approved these changes
Jun 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1665 by removing the call to an internal method which is no longer present in
realm@12.