fix: #29 #67 fix modal height issue (#95)

reapit · Apr 10, 2024 · f5f3e6b · f5f3e6b
1 parent 746bf52
commit f5f3e6b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/components/modal/__styles__/index.ts b/src/components/modal/__styles__/index.ts
@@ -20,7 +20,7 @@ export const ElModalBg = styled.div`
 
 export const ElModal = styled.div`
   display: none;
-  top: 40%;
+  top: 50%;
   left: 50%;
   transform: translate(-50%, -50%);
   box-shadow: 0px 4px 16px 0px rgba(34, 43, 51, 0.16);
@@ -30,6 +30,8 @@ export const ElModal = styled.div`
   width: 65%;
   min-width: 300px;
   max-width: 800px;
+  max-height: 80vh;
+  overflow: auto;
   padding: 1.25rem 1.5rem;
 
   &.${elIsActive} {

diff --git a/src/storybook/changelog.mdx b/src/storybook/changelog.mdx
@@ -19,6 +19,7 @@ Beta versions should be relatively stable but subject to occssional breaking cha
 ### **4.3.0 - 11/04/24**
 
 - Fixes issue where inline PersistentNotification z-index interfeares with Nav
+- Fixes issue where Modal goes off the screen if too much content is included. Now scrolls and has a max height.
 
 ### **4.2.0 - 10/04/24**