Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ui tweak to make badge position fixed #232

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

ss-dimasm
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #

part of #192, minor UI tweak for BottomBarItem. The badge position is breaks when composed in wider components and a little typo font size usage on there

Copy link

codacy-production bot commented Dec 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b53ae81 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b53ae8) Report Missing Report Missing Report Missing
Head commit (4b11bf1) 4367 3912 89.58%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#232) 18 18 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty
Copy link
Contributor

@ss-dimasm can you please add screenshots showing before and after? 🙏

@ss-dimasm
Copy link
Contributor Author

ss-dimasm commented Dec 5, 2024

@kurtdoherty , this is the visual; the badge position is more cornered than before

left is in this PR, right is in main

{E505805B-A8BA-4A97-ABF2-8366419F25F0}

and it will also have the flex: 1 1 0 property to automatically fill available space within a flex container

@ss-dimasm
Copy link
Contributor Author

@kurtdoherty, hold on I surprised the total files changed is 32 and it's more than 1000 lines 😱😱, fixing

@kurtdoherty
Copy link
Contributor

@ss-dimasm thanks for the details 🙏 This PR currently includes a bunch of changes that I think belong to other branches we've merged in. If you aren't already rebasing your branch onto latest, can you please do so. Ideally, this branch only includes the changes relevant to it; not historical changes that have been pulled in from main.

@ss-dimasm ss-dimasm force-pushed the feat/224-bottom-bar-item-ui-tweak branch from 4b11bf1 to 0b9d384 Compare December 5, 2024 06:59
@ss-dimasm
Copy link
Contributor Author

apologies @kurtdoherty, I didn't notice while rebasing

Copy link

codacy-production bot commented Dec 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f37b6dd1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f37b6dd) Report Missing Report Missing Report Missing
Head commit (e2e868a) 4422 3969 89.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#232) 9 9 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@kurtdoherty kurtdoherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

<ElBottomBarItemBadge role="status" />
<ElBottomBarItemContent>
<ElBottomBarItemIcon>{args?.icon}</ElBottomBarItemIcon>
<ElBottomBarItemBadge role="status" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick: I don't think status is an appropriate ARIA role. I'm not sure what is, but when I read the MDN docs on the status role, it doesn't feel quite right 🤷

Copy link
Contributor Author

@ss-dimasm ss-dimasm Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think status is an appropriate ARIA role.

ah yes, I forgot to remove it for storybook styles usage after we've agree on this feedback

@ss-dimasm ss-dimasm merged commit 1e4977d into main Dec 6, 2024
6 checks passed
@ss-dimasm ss-dimasm deleted the feat/224-bottom-bar-item-ui-tweak branch December 6, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants