Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #163 fix menu "show code" doesn't show expected code #254

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

nurm717123
Copy link
Contributor

@nurm717123 nurm717123 commented Dec 16, 2024

The Menu mdx docs doesn't show the expected code, its apparently because storybook doesn't support to add controls for react compound component, the fix is to remove the controls and the controls will be represented by available stories instead as the previous controls is just boolean.

previous:

image

fixed:

image

fixes: #163

new docs:

menudocs

@nurm717123 nurm717123 changed the title fix: #163 fix menu "show code" doesn fix: #163 fix menu "show code" doesn't show expected code Dec 16, 2024
Copy link

codacy-production bot commented Dec 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7be95411
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7be9541) Report Missing Report Missing Report Missing
Head commit (be8fbbe) 4518 4059 89.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#254) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@ksolanki7 ksolanki7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Looks good.

@nurm717123 nurm717123 merged commit bd661b8 into main Dec 20, 2024
6 checks passed
@nurm717123 nurm717123 deleted the 163-menu-fix-docs branch December 20, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 new components: Menu (basic) and MenuButton
2 participants