Skip to content

chore: remove fallback css variables for MobileNavItem and amend the stories #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ss-dimasm
Copy link
Contributor

@ss-dimasm ss-dimasm commented Dec 16, 2024

Pull request checklist

Detail as per issue below (required):

fixes: #206

addition amendment to not store the fallback CSS variable values in MobileNavItem, and amend the story files to able show the correct example on how to use in React usage

Copy link

codacy-production bot commented Dec 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8e5182c1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8e5182c) Report Missing Report Missing Report Missing
Head commit (bb068b1) 4512 4054 89.85%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#255) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ss-dimasm ss-dimasm changed the title chore: remove fallback css variables for MobileNavMenu and amend the stories chore: remove fallback css variables for MobileNavItem and amend the stories Dec 16, 2024
@ss-dimasm ss-dimasm merged commit 2660c86 into main Dec 17, 2024
6 checks passed
@ss-dimasm ss-dimasm deleted the chore/#206-remove-fall-back-css-variable branch December 17, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 new component: MobileNavItem
2 participants