-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #253 new app-bar (existing app switcher) #261
Conversation
…e-existing-app-switcher
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nurm717123 👏 I'm approving on the assumption you'll move those custom styles inside NavResponsiveAppSwitcher
somehow. Everything else looks fine 👍
Thanks, I will do that 👍 |
this is small part of the app-bar component, which will be used in the top bar navigation.
app bar (parent)
this ticket
note: this component is just a wrapper to use existing app-switcher in the new
TopBar