Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: #206 convert expandable mobile nav item to be stateless #264

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ss-dimasm
Copy link
Contributor

@ss-dimasm ss-dimasm commented Dec 26, 2024

Pull request checklist

Detail as per issue below (required):

part of #206

no UI changed, but only how this component should behave when facing with outer world integration

context: #236 (comment)

The new behavior would resolves upper-level integration issues (like React Router) by avoiding internal state management. The parent component defines the source of truth for expanded/collapsed states. This ensures the component follows the defined guidance. This will allow the upper config to immediately close another item group once another page from another group mobile nav menu independently of click listeners or external events that modify the configuration's active state

  • The isActive prop is required when using the expandable version
  • Add an additional onClick prop to the expandable component, which will refer to the button constraint area
  • Remove the isolated state previously defined within the expandable component
  • Remove the HTML Storybook markup from the mobile nav item expandable story

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for bd661b81 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd661b8) Report Missing Report Missing Report Missing
Head commit (a12c7da) 4517 4058 89.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#264) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant