-
Notifications
You must be signed in to change notification settings - Fork 4
feat:#243 add features component #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
@ss-dimasm The issue you discussed with me is maybe the race condition on the visibility of the Tooltip v/s the placement of the tooltip on the canvas. The solution to that can be adding data attribute to tooltip by updating the useTooltip hook -> getTooltipProps i.e.
|
Hey @ksolanki7 while I agree it's caused by the race condition that appear between javascript logic and the canvas, and we would fix it with CSS solution I suppose it would be more handy if it have their own isolated ticket; hence it's not only appearing in the Features and I believe as far as it not changing the API it would not cause a major change, what do you say? |
@ss-dimasm Yes, definately. This requires changes in the Tooltip itself i.e. at the component level and not at the consumer end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the one question which may or may not be a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ss-dimasm. Just the one todo off the back of your answer.
Pull request checklist
Detail as per issue below (required):
part of #243
Context
Initialize a new component as part of elements v5 'Features
Design:
Preview (with Tooltip support):
2025-01-17_16-31-30.mp4