-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: #272 v5-label-component-deprecated-existing #274
chore: #272 v5-label-component-deprecated-existing #274
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpt-rfoxy nit-pick - Deprecate the styles as well with the @deprecated JSDoc tag to have better visual representation over the IDE>
hi @ksolanki7 i already update Deprecate the styles as well with the @deprecated JSDoc tag, please take a look on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@rpt-rfoxy if there's nothing specific that you want my attention/input on in this PR, I don't think I need to review it. |
Pull request checklist
Detail as per issue below (required):
this PR is for deprecating label because label will have new design flow and new requerment
fixes: #272