Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #272 v5-label-component-deprecated-existing #274

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

rpt-rfoxy
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):
this PR is for deprecating label because label will have new design flow and new requerment
fixes: #272

Copy link

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 44eb3091 80.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (44eb309) Report Missing Report Missing Report Missing
Head commit (e4a4e67) 4538 4069 89.67%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#274) 15 12 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@ksolanki7 ksolanki7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@ksolanki7 ksolanki7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpt-rfoxy nit-pick - Deprecate the styles as well with the @deprecated JSDoc tag to have better visual representation over the IDE>

@rpt-rfoxy
Copy link
Contributor Author

hi @ksolanki7 i already update Deprecate the styles as well with the @deprecated JSDoc tag, please take a look on it

@ksolanki7 ksolanki7 self-requested a review January 14, 2025 01:01
Copy link
Contributor

@ksolanki7 ksolanki7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurtdoherty
Copy link
Contributor

@rpt-rfoxy if there's nothing specific that you want my attention/input on in this PR, I don't think I need to review it.

@rpt-rfoxy rpt-rfoxy merged commit 08365a4 into main Jan 16, 2025
6 checks passed
@rpt-rfoxy rpt-rfoxy deleted the feat-272-v5-label-component-deprecated-existing branch January 16, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 component refactor: LabelText
3 participants