feat: added comboboxes aria labels #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashleigh
changed the title
willmcvay
requested changes
Mar 5, 2024
| @@ -70,50 +70,44 @@ export interface CardProps extends HTMLAttributes<HTMLDivElement> { | |||
| isSelected?: boolean // Does the card have the blue selected border | |||
| } | |||
|
|
|||
| export const handleToggleContextMenu = ( | |||
There was a problem hiding this comment.
Weird formatting - can you run yarn lint --fix just to check please
There was a problem hiding this comment.
Have done. No change 👍🏼
There was a problem hiding this comment.
When I check out your branch and run it, I get like 16 file changes
There was a problem hiding this comment.
If you look in your node_modules, which version of prettier do you have? I get 3.2.5 - maybe you need to do a yarn install?
There was a problem hiding this comment.
looks like a cache issue with eslint maybe?
willmcvay
approved these changes
Mar 6, 2024
willmcvay
added a commit
that referenced
this pull request
Mar 7, 2024
* feat: #18 final tidy (#26) * [create-pull-request] automated change (#27) Co-authored-by: willmcvay <willmcvay@users.noreply.github.com> * chore: #16 upgrade to storybook 7 without prettier (#28) * chore: upgrade to storybook 7 * feat: remove vite storybook package * feat: added timeout func to resolve html rendering block * chore: #16 vite working * chore: #16 all working before removing old libs * chore: #16 all passing, let's try upgrading stories * chore: #16 completes v7 migration * chore: #16 tested all components and stories, full sweep --------- Co-authored-by: Ashleigh Simonelli <ashleighsimonelli@gmail.com> * chore: upgrade prettier (#31) * fix: corrected title of change log storybook component * chore: updated prettier * fix: resolved prettier html praser issue * chore: updated prettier eslint plugin package * chore: ran linting with latest perttier plugin * docs: added prettier update to change log (#32) * docs: added change log note * chore: move change log item to previous item * feat: #22 acessibility and general fixes (#34) * fix: resolved rendering of accordion component * fix: reverted key to index * chore: renamed storybook main file as warning says v8 esm only * chore: attempting to resolve storybook issues * refactor: used story source to compile html of components * chore: revert changes made debugging memory leak * refactor: converted to fancy code blocks * chore: reverted prettier version * refactor: resolved html source components * fix: readded argstable for accordion * refactor: added sources for utilities * fix: resolve prettier linting issue by reverting eslint-plugin-prettier * fix: added context to theming html render block * chore: fix linting of all story components * refactor: updated argstable to controls for v8 * feat: added aria labels to accordion * feat: breadcrumb aira labels * feat: added aria labels to icon, file input and key value list * feat: added accessibility labels to mobile control component * feat: added aria labels to modal * feat: updated snaps with aria labels etc * feat: added accessibility labels to pagination items * feat: added roles to placeholder and persistent notification * feat: added aria labels to progress bar * feat: tooltip aria labels * feat: added roles and aria labels to table components * feat: added role attributes to tabs * feat: #22 lints files, fixes html renderer --------- Co-authored-by: Will McVay <wmcvay@reapit.com> * feat: #22 gitHub mdx table replacements (#37) * feat: added margin to custom html story component * chore: remove mdx ghf package * refactor: replaced markdown tables with html tables * chore: updated snaps * feat: #17 update to v8 (#38) * feat: attempting to upgrade storybook to v8 * refactor: changed prettier format method to async * chore: added storybook preview api packages * fix: remove imported argstable component * feat: #17 fixed html render * feat: #17 fixed html render * chore: updated changelog with v8 changes * fix: corrected theming * docs: added info on brand image * feat: #17 various ui and story fixes --------- Co-authored-by: Will McVay <wmcvay@reapit.com> * [create-pull-request] automated change (#39) Co-authored-by: willmcvay <willmcvay@users.noreply.github.com> * chore: update manifest (#45) * feat: added decorated deprecate methods (#46) * feat: added decorated deprecate methods * docs: added intellisense deprecated messages --------- Co-authored-by: Will McVay <wmcvay@reapit.com> * docs: added intellisense deprecated messages (#47) * feat: added comboboxes aria labels (#48) * feat: added comboxes aria labels * feat: updated snaps * chore: linting * fix: issue with eslint cache? * feat: unstyled anchor element (#49) * feat: added unstyled anchor element * refactor: breadcrumbs to use anchors * replaced accordion title with unstyled anchor * chore: linting * feat: updated snaps and corrected accordion title type * refactor: removed extending of styled component * fix: corrected snapahots * refactor: removed unstyled anchor * refactor: change accordion from title to item as anchor * fix: removed condition preventing breadcrumb rendering * fix: corrected storybook issue with breadcrumbs * fix: resolved linting after clearing eslint cache * docs: added changelog entry * feat: #22 adds semantic typography tags (#51) * feat: #22 adds semantic typography tags * refactor: added tagged component for layout components * chore: changed extending of interface * chore: linting * docs: added changelog entry * fix: remove deprecated element components * chore: remove unused import * feat: added tests for layout components with tag property * feat: added typography tests for tagged typography abstract component --------- Co-authored-by: Will McVay <wmcvay@reapit.com> * chore: removes some deprecation warnings --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: willmcvay <willmcvay@users.noreply.github.com> Co-authored-by: Ashleigh Simonelli <ashleighsimonelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Detail as per issue below (required):
fixes: #