fix(deps): pin bincode to v1.3 for API compatibility#12
Closed
Lenvanderhof wants to merge 1 commit intomainfrom
Closed
fix(deps): pin bincode to v1.3 for API compatibility#12Lenvanderhof wants to merge 1 commit intomainfrom
Lenvanderhof wants to merge 1 commit intomainfrom
Conversation
- bincode 2.0+ has a completely new API (Encode/Decode traits) - Code uses legacy 1.x serialize()/deserialize() functions - Pin to bincode 1.3.3 (latest 1.x) until code is migrated to 2.x API - Remove Cargo.lock from .gitignore for reproducible CI builds - Track Cargo.lock for --locked builds Note: Migration to bincode 2.x requires updating all serialization code to use the new Encode/Decode derive macros. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing to fix author info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bincodeto 1.3.3 (latest 1.x) for API compatibilityEncode/Decodetrait APIserialize()/deserialize()functionsCargo.lockfrom.gitignorefor reproducible CI with--lockedflagWhy not bincode 2.0?
bincode 2.0 requires migrating from:
To new 2.x API:
This requires changes across multiple modules. Using 1.3.3 (latest 1.x) now to unblock CI.
Future Work
Consider migrating to bincode 2.x API for improved performance and features.
Test Plan
--lockedsucceeds🤖 Generated with Claude Code