fix(ci): align docs job with docs.rs metadata configuration #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig The docs.rs build uses `features = ["compression"]` in Cargo.toml metadata. Using --all-features fails because python/local-embeddings require system dependencies not available on docs.rs. This aligns the CI docs job with the docs.rs configuration.
There was a problem hiding this comment.
Pull request overview
This PR aligns the CI documentation build job with the docs.rs metadata configuration to ensure the CI environment accurately reflects what will be built on docs.rs. The change switches from using --all-features to --features compression to avoid features that require system dependencies not available on docs.rs.
Changes:
- Updated CI docs job to use
--features compressioninstead of--all-features - Added explanatory comments about why python and local-embeddings features are excluded
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[package.metadata.docs.rs]configuration--features compressioninstead of--all-featuresto avoid features requiring system deps not available on docs.rs (python, local-embeddings)Changes
.github/workflows/ci.ymldocs job to use--features compressionTest plan
🤖 Generated with Claude Code