chore: more database name

recca0120 · Jul 24, 2020 · b047c33 · b047c33
1 parent 7a65755
commit b047c33
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 44 deletions.
diff --git a/README.md b/README.md
@@ -19,8 +19,10 @@ when you use sqlite in PHPUnit and you need MySQL version sql, you can set drive
 ```php
 // eloquent-dumper.php
 return [
-    // Supported: "pdo", "mysql", "sqlite", "postgres", "mssql"
-    'driver' => env('ELOQUENT_DUMPER_GRAMMAR', 'mysql'),
+    /*
+     * Supported: "pdo", "mysql", "sqlite", "pgsql", "sqlsrv"
+     */
+    'driver' => env('ELOQUENT_DUMPER_GRAMMAR', 'pdo'),
 ];
 ```
 ## How to use

diff --git a/config/eloquent-dumper.php b/config/eloquent-dumper.php
@@ -2,7 +2,7 @@
 
 return [
     /*
-     * Supported: "pdo", "mysql", "sqlite", "postgres", "mssql"
+     * Supported: "pdo", "mysql", "sqlite", "pgsql", "sqlsrv"
      */
     'grammar' => env('ELOQUENT_DUMPER_GRAMMAR', 'pdo'),
 ];
diff --git a/src/Dumper.php b/src/Dumper.php
@@ -10,12 +10,14 @@
 
 class Dumper
 {
-    const PDO = 'pdo';
     const NONE = 'none';
+    const PDO = 'pdo';
     const MYSQL = 'mysql';
     const SQLITE = 'sqlite';
     const POSTGRES = 'postgres';
+    const PGSQL = 'pgsql';
     const SQLSERVER = 'sqlserver';
+    const SQLSRV = 'sqlsrv';
     const MSSQL = 'mssql';
 
     /**

diff --git a/src/Grammars/Grammar.php b/src/Grammars/Grammar.php
@@ -2,15 +2,20 @@
 
 namespace Recca0120\EloquentDumper\Grammars;
 
+use Recca0120\EloquentDumper\Dumper;
+
 abstract class Grammar
 {
     private static $lookup = [
-        'mysql' => MySqlGrammar::class,
-        'none' => NoneGrammar::class,
-        'postgres' => PostgresGrammar::class,
-        'sqlite' => SQLiteGrammar::class,
-        'sqlserver' => SqlServerGrammar::class,
-        'mssql' => SqlServerGrammar::class,
+        Dumper::NONE => NoneGrammar::class,
+        Dumper::PDO => PdoGrammar::class,
+        Dumper::MYSQL => MySqlGrammar::class,
+        Dumper::SQLITE => SQLiteGrammar::class,
+        Dumper::POSTGRES => PostgresGrammar::class,
+        Dumper::PGSQL => PostgresGrammar::class,
+        Dumper::SQLSERVER => SqlServerGrammar::class,
+        Dumper::SQLSRV => SqlServerGrammar::class,
+        Dumper::MSSQL => SqlServerGrammar::class,
     ];
 
     /**

diff --git a/tests/DumperTest.php b/tests/DumperTest.php
@@ -66,18 +66,18 @@ public function test_it_should_convert_to_none_quote_sql(Builder $query, $expect
     {
         $dumper = $this->givenDumper(Dumper::NONE);
 
-        $query->from('users')->whereIn('id', [1, 2, 3, 4, 5]);
+        $query->from('users')->whereIn('id', [1, null, false, 'foo']);
 
         $this->assertSql($expected, $dumper, $query);
     }
 
     public function noneGrammarProvider()
     {
         return [
-            [$this->mysql(), 'select * from users where id in (1, 2, 3, 4, 5)'],
-            [$this->sqlite(), 'select * from users where id in (1, 2, 3, 4, 5)'],
-            [$this->postgres(), 'select * from users where id in (1, 2, 3, 4, 5)'],
-            [$this->sqlServer(), 'select * from users where id in (1, 2, 3, 4, 5)'],
+            [$this->mysql(), 'select * from users where id in (1, NULL, 0, \'foo\')'],
+            [$this->sqlite(), 'select * from users where id in (1, NULL, 0, \'foo\')'],
+            [$this->postgres(), 'select * from users where id in (1, NULL, 0, \'foo\')'],
+            [$this->sqlServer(), 'select * from users where id in (1, NULL, 0, \'foo\')'],
         ];
     }
 
@@ -90,18 +90,18 @@ public function test_it_should_convert_to_mysql_version_sql(Builder $query, $exp
     {
         $dumper = $this->givenDumper(Dumper::MYSQL);
 
-        $query->from('users')->whereIn('id', [1, 2, 'App\User', 'don\'t be late']);
+        $query->from('users')->whereIn('id', [1, null, false, 'foo', 'App\User', 'don\'t be late']);
 
         $this->assertSql($expected, $dumper, $query);
     }
 
     public function mySQLGrammarProvider()
     {
         return [
-            [$this->mysql(), "select * from `users` where `id` in (1, 2, 'App\\\\User', 'don\'t be late')"],
-            [$this->sqlite(), "select * from `users` where `id` in (1, 2, 'App\\\\User', 'don\'t be late')"],
-            [$this->postgres(), "select * from `users` where `id` in (1, 2, 'App\\\\User', 'don\'t be late')"],
-            [$this->sqlServer(), "select * from `users` where `id` in (1, 2, 'App\\\\User', 'don\'t be late')"],
+            [$this->mysql(), 'select * from `users` where `id` in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\\\'t be late\')'],
+            [$this->sqlite(), 'select * from `users` where `id` in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\\\'t be late\')'],
+            [$this->postgres(), 'select * from `users` where `id` in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\\\'t be late\')'],
+            [$this->sqlServer(), 'select * from `users` where `id` in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\\\'t be late\')'],
         ];
     }
 
@@ -114,18 +114,18 @@ public function test_it_should_convert_to_sqlite_version_sql(Builder $query, $ex
     {
         $dumper = $this->givenDumper(Dumper::SQLITE);
 
-        $query->from('users')->whereIn('id', [1, 2, 'App\User', 'don\'t be late']);
+        $query->from('users')->whereIn('id', [1, null, false, 'foo', 'App\User', 'don\'t be late']);
 
         $this->assertSql($expected, $dumper, $query);
     }
 
     public function sqliteGrammarProvider()
     {
         return [
-            [$this->mysql(), 'select * from "users" where "id" in (1, 2, \'App\\User\', \'don\'\'t be late\')'],
-            [$this->sqlite(), 'select * from "users" where "id" in (1, 2, \'App\\User\', \'don\'\'t be late\')'],
-            [$this->postgres(), 'select * from "users" where "id" in (1, 2, \'App\\User\', \'don\'\'t be late\')'],
-            [$this->sqlServer(), 'select * from "users" where "id" in (1, 2, \'App\\User\', \'don\'\'t be late\')'],
+            [$this->mysql(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\User\', \'don\'\'t be late\')'],
+            [$this->sqlite(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\User\', \'don\'\'t be late\')'],
+            [$this->postgres(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\User\', \'don\'\'t be late\')'],
+            [$this->sqlServer(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\User\', \'don\'\'t be late\')'],
         ];
     }
 
@@ -138,35 +138,21 @@ public function test_it_should_convert_to_postgres_version_sql(Builder $query, $
     {
         $dumper = $this->givenDumper(Dumper::POSTGRES);
 
-        $query->from('users')->whereIn('id', [1, 2, 'App\User', 'don\'t be late']);
+        $query->from('users')->whereIn('id', [1, null, false, 'foo', 'App\User', 'don\'t be late']);
 
         $this->assertSql($expected, $dumper, $query);
     }
 
     public function postgresGrammarProvider()
     {
         return [
-            [$this->mysql(), 'select * from "users" where "id" in (1, 2, \'App\\\\User\', \'don\'\'t be late\')'],
-            [$this->sqlite(), 'select * from "users" where "id" in (1, 2, \'App\\\\User\', \'don\'\'t be late\')'],
-            [$this->postgres(), 'select * from "users" where "id" in (1, 2, \'App\\\\User\', \'don\'\'t be late\')'],
-            [$this->sqlServer(), 'select * from "users" where "id" in (1, 2, \'App\\\\User\', \'don\'\'t be late\')'],
+            [$this->mysql(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\'\'t be late\')'],
+            [$this->sqlite(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\'\'t be late\')'],
+            [$this->postgres(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\'\'t be late\')'],
+            [$this->sqlServer(), 'select * from "users" where "id" in (1, NULL, 0, \'foo\', \'App\\\\User\', \'don\'\'t be late\')'],
         ];
     }
 
-    /**
-     * @dataProvider sqlServerGrammarProvider
-     * @param Builder $query
-     * @param string $expected
-     */
-    public function test_it_should_convert_to_mssql_version_sql(Builder $query, $expected)
-    {
-        $dumper = $this->givenDumper(Dumper::MSSQL);
-
-        $query->from('users')->whereIn('id', [1, 2, 3, 4, 5]);
-
-        $this->assertSql($expected, $dumper, $query);
-    }
-
     /**
      * @dataProvider sqlServerGrammarProvider
      * @param Builder $query