Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .all-contributorsrc #1030

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update .all-contributorsrc #1030

merged 2 commits into from
Oct 23, 2024

Conversation

shubhagarwal1
Copy link
Contributor

This pull request enhances our contributor profile management by following these steps:

Identified New Contributors: Retrieved all open issues titled "ADD Profile" to gather new contributor data.
Data Formatting: Converted the new contributor data to match the existing JSON structure.
Removed Duplicates: Compared the new data against the current all-contributors file to eliminate any duplicate entries.
Merged Profiles: Combined the cleaned contributor data with existing profiles, appending new contributors to the end to maintain order.

@sanjay-kv sanjay-kv added this to the Awesome Launch milestone Oct 23, 2024
@sanjay-kv sanjay-kv merged commit cef3adb into recodehive:main Oct 23, 2024
7 of 9 checks passed
@sanjay-kv
Copy link
Member

This is great update.

Copy link
Member

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add level2 @sanjay-kv

code is formatted and the other existing key-value pair data is added

image

@shubhagarwal1
Copy link
Contributor Author

Add level2 @sanjay-kv

code is formatted and the other existing key-value pair data is added

image

@shubhagarwal1
Copy link
Contributor Author

shubhagarwal1 commented Oct 25, 2024

Add level2 @sanjay-kv

code is formatted and the other existing key-value pair data is added

image

Hey @MastanSayyad I understand your concern, but lot of scrapping effort was also involved, to collect this data, reformating the data according to the file and then placing it corrcectly, please read the PR desc also, the code is just not formatted but also, new records are added, in order to which reformatting was required

@sanjay-kv
Copy link
Member

@MastanSayyad

i personally think there been lot of work involved, some of the work doesn't reflect by just looking at the code changes.
and the impact to the repo was high because our bot stopped working. so this timely intervention made sure customer retention. so I don't think level down is necessary for this @shubhagarwal1

@MastanSayyad
Copy link
Member

I get it, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants