fix(config): nginx heredoc and variable escaping correction #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nx config - Replaced EOF with 'EOF' to avoid shell variable expansion - Removed escaped variables ($var) and kept them as for correct nginx syntax - Ensures the generated config matches expected nginx behavior
jorggr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EOFwith'EOF'in heredoc to avoid unwanted shell variable expansion.\$variable→$variable) in nginx configuration.Motivation
Using unquoted
EOFcaused the shell to expand variables like$hostand$uribefore they reached the config file, breaking nginx behavior.Switching to
'EOF'passes the content literally, allowing nginx to interpret its variables correctly without manual escaping.Impact