Skip to content

Winston/tasks#292

Merged
ElasticBottle merged 38 commits intomainfrom
winston/tasks
Sep 22, 2025
Merged

Winston/tasks#292
ElasticBottle merged 38 commits intomainfrom
winston/tasks

Conversation

@ElasticBottle
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings September 18, 2025 22:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request restructures web scraping and SEO functionality by consolidating crawler packages, introducing new task infrastructure, and creating a dedicated SEO application with comprehensive marketing components.

Key changes:

  • Refactors crawler functionality from a standalone package to a unified task system
  • Creates a new SEO application with complete marketing website infrastructure
  • Migrates TypeScript targets from ES2024 to ESNext for broader compatibility

Reviewed Changes

Copilot reviewed 76 out of 87 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tooling/typescript/tsconfig.base.json Updates TypeScript target and lib from ES2024 to ESNext
packages/task/* New task package replacing crawler with Trigger.dev integration and enhanced content extraction
packages/crawler/* Removes old crawler package files and configurations
apps/seo/* Complete new SEO application with marketing pages, authentication, and onboarding flows
.github/workflows/cloudflare.yml Adds SEO app deployment pipeline

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 18, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/rectangular-labs/monorepo/@rectangular-labs/emails@292
pnpm add https://pkg.pr.new/rectangular-labs/monorepo/@rectangular-labs/result@292

commit: 995d703

@github-actions
Copy link
Contributor

Cloudflare Preview URL for WWW 🎈 : https://pr-292.rectangularlabs.com (custom domain)
Cloudflare Preview URL for SEO 🎈 : https://pr-292.seo.rectangularlabs.com (custom domain)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 124 out of 146 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

packages/task/src/trigger/understand-site.ts:1

  • Using process.exit(1) in a catch block will terminate the entire process abruptly. This prevents proper cleanup and error handling. Consider throwing an error or returning an error result instead.
import { google } from "@ai-sdk/google";

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 124 out of 146 changed files in this pull request and generated 8 comments.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 124 out of 146 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

packages/task/src/trigger/understand-site.ts:1

  • Using process.exit(1) in a catch block is problematic as it abruptly terminates the entire process without proper cleanup. Consider throwing an error or returning a failure result instead to allow proper error handling by the calling code.
import { google } from "@ai-sdk/google";

packages/task/src/lib/extract-sitemap-urls.ts:1

  • The JSDoc comment has an empty description line and uses JavaScript-style parameter documentation in a TypeScript file. Either provide a meaningful description or remove the empty line, and consider using TypeScript-style documentation.
import { log, RobotsTxtFile } from "crawlee";

@ElasticBottle ElasticBottle merged commit fecc647 into main Sep 22, 2025
8 checks passed
@ElasticBottle ElasticBottle deleted the winston/tasks branch September 22, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant