Skip to content

chore: pr comments#396

Merged
ElasticBottle merged 3 commits intomainfrom
winston/pr-comments
Feb 15, 2026
Merged

chore: pr comments#396
ElasticBottle merged 3 commits intomainfrom
winston/pr-comments

Conversation

@ElasticBottle
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 15, 2026 13:18
@gemini-code-assist
Copy link

Summary of Changes

Hello @ElasticBottle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several targeted improvements across the SEO application, focusing on enhancing user experience, system efficiency, and data integrity. Key updates include streamlining frontend API interactions, bolstering the reliability of the content auto-save feature, and optimizing backend workflow processes through parallel execution. Additionally, the changes refine AI-driven content extraction and improve how content-related data, such as notes and strategy IDs, are handled throughout the system.

Highlights

  • Frontend Refinements: Updated API query key access methods in content-display.tsx and manage-content-metadata-dialog.tsx for consistency and simplified useRef usage in the content editor.
  • Content Auto-Save Enhancement: Refactored the content editor's auto-save mechanism to prevent race conditions during asynchronous saves and simplify version tracking.
  • Workflow Optimization: Parallelized the execution of the 'trigger strategy suggestions workflow' and 'generate brand voice' steps within the SEO onboarding workflow, improving efficiency.
  • AI Prompt Improvement: Refined the AI system prompt for extracting company/product names in the onboarding workflow, making it more flexible by considering both homepage title and URL.
  • API and Data Handling Updates: Extended the content listing API to support filtering by strategyId and ensured content notes are correctly passed through in the planner workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • apps/seo/src/routes/_authed/$organizationSlug/$projectSlug/-components/content-display.tsx
    • Removed unused useRef import and associated state variables.
    • Updated queryClient.invalidateQueries to use api.content.list.key({ type: "query" }).
    • Refactored the content auto-save useEffect to prevent race conditions with a cancelled flag.
  • apps/seo/src/routes/_authed/$organizationSlug/$projectSlug/-components/manage-content-metadata-dialog.tsx
    • Updated queryClient.invalidateQueries to use api.content.list.key({ type: "query" }).
  • packages/api-seo/src/routes/content.ts
    • Added strategyId to the listContent function call for content filtering.
  • packages/api-seo/src/workflows/onboarding-workflow.ts
    • Modified the AI system prompt for extracting entity names to be more flexible and consider URLs.
    • Wrapped the 'trigger strategy suggestions workflow' and 'generate brand voice' steps in Promise.all for concurrent execution.
  • packages/api-seo/src/workflows/planner-workflow.ts
    • Updated content creation logic to correctly pass through content.notes instead of a hardcoded '(none)'.
Activity
  • No specific activity (comments, reviews, or progress updates) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several improvements, including a significant refactoring of the auto-save logic in the content editor to a more robust pattern, and a performance enhancement by parallelizing independent steps in the onboarding workflow. The changes also include updates to API calls and AI prompts. I've found one issue in the planner workflow where content notes are not being correctly passed due to a missing parameter when fetching data, which I've detailed in a comment.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 15, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/rectangular-labs/monorepo/@rectangular-labs/emails@396
pnpm add https://pkg.pr.new/rectangular-labs/monorepo/@rectangular-labs/loro-file-system@396
pnpm add https://pkg.pr.new/rectangular-labs/monorepo/@rectangular-labs/result@396

commit: 8170bd8

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses PR review comments by making several refinements to the codebase, including workflow improvements, query invalidation pattern updates, and auto-save logic simplification.

Changes:

  • Enhanced workflow data passing and parallelization for better performance
  • Updated query invalidation to use broader key patterns for consistency
  • Simplified auto-save debouncing logic with a cleaner cancellation approach

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/api-seo/src/workflows/planner-workflow.ts Pass through actual content notes instead of hardcoded "(none)"
packages/api-seo/src/workflows/onboarding-workflow.ts Simplified prompt text and parallelized independent workflow steps for performance
packages/api-seo/src/routes/content.ts Added strategyId parameter for content list filtering
apps/seo/src/routes/_authed/$organizationSlug/$projectSlug/-components/manage-content-metadata-dialog.tsx Updated query invalidation to use broader key pattern
apps/seo/src/routes/_authed/$organizationSlug/$projectSlug/-components/content-display.tsx Simplified auto-save logic by replacing version tracking with cancellation flag approach

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aac0c603c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link
Contributor

Cloudflare Preview URL for WWW 🎈 : https://pr-396.rectangularlabs.com (custom domain)
Cloudflare Preview URL for SEO 🎈 : https://pr-396.fluidposts.com (custom domain)
Cloudflare Preview URL for SEO WWW 🎈 : https://www-pr-396.fluidposts.com (custom domain)
Cloudflare Preview URL for SEO Contact 🎈 : https://contact-pr-396.fluidposts.com (custom domain)

@ElasticBottle ElasticBottle enabled auto-merge (squash) February 15, 2026 13:29
@ElasticBottle ElasticBottle merged commit 0739625 into main Feb 15, 2026
8 of 9 checks passed
@ElasticBottle ElasticBottle deleted the winston/pr-comments branch February 15, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant