Keep selectable intersection when improving doctrine collection doc type #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually adding selectable everywhere seems like a fix in wrong place. This should be fixed in Doctrine itself, or PHPStan extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #342.
I do have an issue with one of the tests, as the
PhpDocTypeChangerincorrect detects the types as changed, causing it to change it every time as the test indicates. Some help to fix this would be appreciated, or....It might actually be better to not touch the doc type at all when it already contains the
<int,, but I do not think I can implement that correctly (or swiftly)