Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 support #6701

Closed
wants to merge 1 commit into from
Closed

Conversation

sofiiakulish
Copy link

No description provided.

@sofiiakulish
Copy link
Author

sofiiakulish commented Jan 28, 2025

As a continue for #6698
I reverted the changes related to .inc files.
If we want to support PHP8.4 we need to put the current default value for escape argument of str_getcsv function as without it the error is triggered

str_getcsv(): the $escape parameter must be provided as its default value will change

image

@samsonasik
Copy link
Member

Please stop updating test files, that's there on purpose, and update str_getcsv needs test as it already default to \\.

@samsonasik samsonasik closed this Jan 28, 2025
@samsonasik
Copy link
Member

Test is needed.

@sofiiakulish
Copy link
Author

sofiiakulish commented Jan 28, 2025

@samsonasik Why are you closing the PR?
If the test is needed wait for my extra push.

What are your plans for the support PHP8.4 if my PRs you don't want to consider?

@samsonasik
Copy link
Member

because no test as I already suggest in your previous PR, and you keep updating test files, which unrelated.

@rectorphp rectorphp locked as spam and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants