Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector. #6721

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector. #6721

merged 1 commit into from
Feb 6, 2025

Conversation

mickverm
Copy link
Contributor

@mickverm mickverm commented Feb 6, 2025 •
edited
Loading

The following configuration has been in our codebase for quite some time, so I figured it's about time to patch it directly into Rector. I based my changes on a similar issue: #6531.

->withSkip([
    ReadOnlyPropertyRector::class => [
        __DIR__ . '/src/Document/*.php',
    ],
])

@samsonasik samsonasik merged commit ecd8b37 into rectorphp:main Feb 6, 2025
44 checks passed
@samsonasik
Copy link
Member

Thank you @mickverm

@mickverm
Copy link
Contributor Author

mickverm commented Feb 6, 2025

That was quick! 🥳

@mickverm mickverm deleted the readonlypropertyrector-doctrine-mongodb-odm branch February 6, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickverm @samsonasik