DoctrineTargetEntityStringToClassConstantRector should keep self::class

[OskarStark]

Bug Report

Subject	Details
Rector version	e.g. v0.17.6

self::class should not be refactored

Minimal PHP Code Causing Issue

I tried to reproduce the error in a demo here:
https://getrector.com/demo/f95978a5-496b-4e3a-bcfe-e8fe06141988

but it does not refactor anything, while in my code I see:

Expected Behaviour

self::class is valid and should be kept, because if this gets refactored to App\Entity\Deadline, my PHP-CS-Fixer comes and fixes it back to self::class, so I end up in an infinite loop.

I am unable to create a failing test case :-(

[TomasVotruba]

Hi, the screenshot shows 3 rules being active at the same time. Could you re-run your local rector.php with only DoctrineTargetEntityStringToClassConstantRector? What is the output?

I made a test fixture for only DoctrineTargetEntityStringToClassConstantRector but is passes, so it will be combination of rules causing this.

What's your minimal rector.php setup causing this?

[OskarStark]

In the end I skipped this rule and everything is fine, even when skipping the other mentioned rules and activating only the DoctrineTargetEntityStringToClassConstantRector, I receive:

I enabled all the three rules here, but still no error:
https://getrector.com/demo/a916553a-9f8a-4bde-9b5a-05c12e924a3b

Not sure if the demo really gets, that it is a Doctrine entity class... 🤔

[TomasVotruba]

My test fixture is passing well, and demo is working the same 👍

---

Could you share minimal rector.php that is causing this? I think there will be missconfiguration in your autoloading.

[OskarStark]

I will try, but gave some more hints in

• Add self reference test case for DoctrineTargetEntityStringToClassConstantRector rector-doctrine#211

[samsonasik]

@TomasVotruba @OskarStark it already resolved in PR:

• [CodeQuality] Keep self::class on DoctrineTargetEntityStringToClassConstantRector rector-doctrine#208

please use rector dev-main

[TomasVotruba]

Ah, I see :) I'll make a new release then. Thanks @samsonasik 👍

[OskarStark]

Thanks 👏