Add self reference test case for DoctrineTargetEntityStringToClassConstantRector

[TomasVotruba]

Test fixture for rectorphp/rector#8081

[OskarStark]

Do we need the #[Entity] Attribute here?

[TomasVotruba]

Good point, just added 👍

[TomasVotruba]

Checking other fixtures, it's actually not needed. This rules checks directly these annotations/attributes.

There already is another test fixture for self::class as well 👍

See: https://github.com/rectorphp/rector-doctrine/blob/main/rules-tests/CodeQuality/Rector/Property/DoctrineTargetEntityStringToClassConstantRector/Fixture/Attribute/keep_self.php.inc

[OskarStark]

Maybe add:
#[ORM\JoinColumn(name: 'some_entity', onDelete: 'SET NULL')

from my screenshot

[OskarStark]

Ah the difference is, in your existing test you use private ?self.....

while here is no type hint.

Please do:

- private $someEntity;
+ private KeepSelfReference $someEntity;

if this does not work, try to make it nullable:

- private $someEntity;
+ private ?KeepSelfReference $someEntity;

[samsonasik]

@TomasVotruba @OskarStark it already resolved in PR:

• [CodeQuality] Keep self::class on DoctrineTargetEntityStringToClassConstantRector #208

please use rector dev-main

[TomasVotruba]

Thanks 👍