Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fixes from the maxent paper #116

Merged
merged 36 commits into from
Feb 26, 2024
Merged

add fixes from the maxent paper #116

merged 36 commits into from
Feb 26, 2024

Conversation

SobhanMP
Copy link
Contributor

@SobhanMP SobhanMP commented Feb 6, 2024

No description provided.

@SobhanMP SobhanMP requested a review from bengioe as a code owner February 6, 2024 07:06
@bengioe bengioe mentioned this pull request Feb 6, 2024
Open
bengioe
bengioe reviewed Feb 8, 2024
View reviewed changes
src/gflownet/models/graph_transformer.py Outdated Show resolved Hide resolved
src/gflownet/trainer.py Outdated Show resolved Hide resolved
src/gflownet/data/qm9.py Outdated Show resolved Hide resolved
src/gflownet/tasks/qm9_moo.py Outdated Show resolved Hide resolved
src/gflownet/tasks/qm9_moo.py Outdated Show resolved Hide resolved
src/gflownet/trainer.py Outdated Show resolved Hide resolved
src/gflownet/utils/metrics.py Outdated Show resolved Hide resolved
src/gflownet/utils/multiobjective_hooks.py Outdated Show resolved Hide resolved
src/gflownet/trainer.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@SobhanMP
Copy link
Contributor Author

SobhanMP commented Feb 9, 2024

Just in case, please don't merge

@SobhanMP
Copy link
Contributor Author

Having a generic moo class would be so nice.
BTW the moo task did not support having the FR in an order other than the default...

@SobhanMP
Copy link
Contributor Author

It may be a stupid realization but generate_forward_trajectory is subsumed by sample_backward_from_graphs by setting model=False.

@SobhanMP
Copy link
Contributor Author

SobhanMP commented Feb 17, 2024 •
edited
Loading

@bengioe is the List[Dict[str, Any]] ok in trajectory_balance.py? mypy complaints otherwise as the inferred type for the list is too restrictive.

@SobhanMP
Copy link
Contributor Author

things definitely run now

@bengioe bengioe merged commit aa15f27 into recursionpharma:trunk Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengioe bengioe bengioe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SobhanMP @bengioe