Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize get_version and remove types-pkg_resources #139

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

dmaljovec
Copy link
Contributor

update from legion on behalf of @dmaljovec

This will help prevent roadie lock issues stemming from usage of a "yanked" package

@dmaljovec dmaljovec requested a review from bengioe as a code owner October 2, 2024 17:25
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@bengioe bengioe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this particular notebook was changed, but it appears to just be formatting 👍
LGTM

@dmaljovec
Copy link
Contributor Author

Not sure why this particular notebook was changed, but it appears to just be formatting 👍 LGTM

Ah, sorry. the idea was to find and replace a block of code programmatically and then run ruff against the codebase. The script did not find the code it wanted to replace, and so there was no need to reformat any code here. I am updating the PR to be a more targeted change to hopefully make it more clear the actual intent of what we were trying to update here.

@dmaljovec dmaljovec merged commit 7d19cdf into trunk Dec 20, 2024
4 checks passed
@dmaljovec dmaljovec deleted the legion-2024-10-02-b254c79a branch December 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants