-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize depmap driver analysis #37
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Some of the functions could use better doc strings, but I'm going to add another notebook to generate the new box & scatter plots so I can do that on that PR.
in depmap/process
:
split_models
the behavior isn't really obvious from the code, so a doc string with a description would be good.- Docstring for
bootstrap_stats
is just a list of parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
What?
process.py
which is used for depmap driver analysisproxbias/notebooks/DepMap_PB_Driver_Analysis.ipynb
andproxbias/notebooks/DepMap_PB_Sample.ipynb
to include analysis performed and sample of how to use driver codeWhy?