Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding stemplot to readme #57

Closed
wants to merge 1 commit into from

Conversation

nanobowers
Copy link
Contributor

Per @kojix2 request in issue #56

I am unsure how to generate png images in the same style as the original documentation, so instead just added some markdown. That said, the stemplot is not as graphical as the other plot types.

@kojix2
Copy link
Member

kojix2 commented Jul 5, 2021

Yes, I think it's better to keep the same image style if possible.
But I do appreciate your effort on this pull request!

@nanobowers
Copy link
Contributor Author

@kojix2 Maybe if @mrkn can provide the terminal settings and font selection, then i can produce .png images similar to the other one images he has given using the examples? Or perhaps this is a better request for @mrkn ? Feel free to use whichever examples (either in this PR or in the examples/ex_stemplot.rb)...

@mrkn
Copy link
Member

mrkn commented Jul 6, 2021

I will do it. But, maybe I cannot do it soon because I'm very busy this month.

@mrkn mrkn self-assigned this Jul 19, 2021
@nanobowers
Copy link
Contributor Author

Withdrawing this pull request, since @mrkn has offered to do this in a consistent style with the other images.

@nanobowers nanobowers closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants