[RHOAIENG-11326] Creating new pipeline from Create Run Page redirects…

… to the pipeline detail page (opendatahub-io#3262)
red-hat-data-services · Sep 27, 2024 · 250c555 · 250c555
1 parent 50a1054
commit 250c555
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/frontend/src/concepts/pipelines/content/createRun/contentSections/PipelineSection.tsx b/frontend/src/concepts/pipelines/content/createRun/contentSections/PipelineSection.tsx
@@ -60,6 +60,7 @@ const PipelineSection: React.FC<PipelineSectionProps> = ({
               variant="link"
               icon={<PlusCircleIcon />}
               onCreate={onPipelineChange}
+              redirectAfterImport={false}
             >
               Create new pipeline
             </ImportPipelineButton>

diff --git a/frontend/src/concepts/pipelines/content/import/ImportPipelineButton.tsx b/frontend/src/concepts/pipelines/content/import/ImportPipelineButton.tsx
@@ -6,11 +6,13 @@ import { PipelineKFv2 } from '~/concepts/pipelines/kfTypes';
 
 type ImportPipelineButtonProps = {
   onCreate?: (pipeline: PipelineKFv2) => void;
+  redirectAfterImport?: boolean;
 } & Omit<React.ComponentProps<typeof Button>, 'onClick'>;
 
 const ImportPipelineButton: React.FC<ImportPipelineButtonProps> = ({
   onCreate,
   children,
+  redirectAfterImport,
   ...buttonProps
 }) => {
   const { apiAvailable, refreshAllAPI, pipelinesServer } = usePipelinesAPI();
@@ -28,6 +30,7 @@ const ImportPipelineButton: React.FC<ImportPipelineButtonProps> = ({
       </Button>
       <PipelineImportModal
         isOpen={open}
+        redirectAfterImport={redirectAfterImport}
         onClose={(pipeline) => {
           setOpen(false);
           if (pipeline) {

diff --git a/frontend/src/concepts/pipelines/content/import/PipelineImportModal.tsx b/frontend/src/concepts/pipelines/content/import/PipelineImportModal.tsx
@@ -31,9 +31,14 @@ import { PipelineUploadOption, extractKindFromPipelineYAML } from './utils';
 type PipelineImportModalProps = {
   isOpen: boolean;
   onClose: (pipeline?: PipelineKFv2) => void;
+  redirectAfterImport?: boolean;
 };
 
-const PipelineImportModal: React.FC<PipelineImportModalProps> = ({ isOpen, onClose }) => {
+const PipelineImportModal: React.FC<PipelineImportModalProps> = ({
+  isOpen,
+  redirectAfterImport = true,
+  onClose,
+}) => {
   const navigate = useNavigate();
   const { project, api, apiAvailable, namespace } = usePipelinesAPI();
   const [importing, setImporting] = React.useState(false);
@@ -73,11 +78,11 @@ const PipelineImportModal: React.FC<PipelineImportModalProps> = ({ isOpen, onClo
       );
       const versionId = versions?.[0].pipeline_version_id;
 
-      if (versionId) {
+      if (redirectAfterImport && versionId) {
         navigate(pipelineVersionDetailsRoute(namespace, pipeline.pipeline_id, versionId));
       }
     },
-    [api, namespace, navigate, onBeforeClose],
+    [api, namespace, redirectAfterImport, navigate, onBeforeClose],
   );
 
   const checkForDuplicateName = useDebounceCallback(