Merge pull request opendatahub-io#2935 from Gkrumbach07/v2.24.0-fixes

remove artifact preview
red-hat-data-services · Jun 20, 2024 · 310dfdd · 310dfdd
2 parents 37bd8c7 + d3c109d
commit 310dfdd
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 88 deletions.
diff --git a/...concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDetails.tsx b/...concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDetails.tsx
@@ -10,7 +10,6 @@ import {
   DescriptionListGroup,
   DescriptionListTerm,
   DescriptionListDescription,
-  StackItem,
 } from '@patternfly/react-core';
 
 import { Artifact } from '~/third_party/mlmd';
@@ -21,7 +20,6 @@ import PipelinesTableRowTime from '~/concepts/pipelines/content/tables/Pipelines
 import PipelineRunDrawerRightContent from '~/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDrawerRightContent';
 import { SupportedArea, useIsAreaAvailable } from '~/concepts/areas';
 import { ArtifactUriLink } from '~/concepts/pipelines/content/artifacts/ArtifactUriLink';
-import ArtifactPreview from '~/concepts/pipelines/content/pipelinesDetails/taskDetails/ArtifactPreview';
 
 type ArtifactNodeDetailsProps = Pick<
   React.ComponentProps<typeof PipelineRunDrawerRightContent>,
@@ -90,14 +88,7 @@ export const ArtifactNodeDetails: React.FC<ArtifactNodeDetailsProps> = ({
             <DescriptionListGroup>
               <DescriptionListTerm>{artifactName}</DescriptionListTerm>
               <DescriptionListDescription>
-                <Stack hasGutter>
-                  <StackItem>
-                    <ArtifactUriLink uri={artifact.getUri()} />
-                  </StackItem>
-                  <StackItem>
-                    <ArtifactPreview artifact={artifact} />
-                  </StackItem>
-                </Stack>
+                <ArtifactUriLink uri={artifact.getUri()} />
               </DescriptionListDescription>
             </DescriptionListGroup>
           </DescriptionList>

diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/taskDetails/ArtifactPreview.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/taskDetails/ArtifactPreview.tsx
diff --git a/...nd/src/concepts/pipelines/content/pipelinesDetails/taskDetails/TaskDetailsInputOutput.tsx b/...nd/src/concepts/pipelines/content/pipelinesDetails/taskDetails/TaskDetailsInputOutput.tsx
@@ -4,7 +4,6 @@ import TaskDetailsSection from '~/concepts/pipelines/content/pipelinesDetails/ta
 import TaskDetailsPrintKeyValues from '~/concepts/pipelines/content/pipelinesDetails/taskDetails/TaskDetailsPrintKeyValues';
 import { PipelineTaskArtifact } from '~/concepts/pipelines/topology';
 import { ArtifactUriLink } from '~/concepts/pipelines/content/artifacts/ArtifactUriLink';
-import ArtifactPreview from './ArtifactPreview';
 
 type TaskDetailsInputOutputProps = {
   type: 'Input' | 'Output';
@@ -29,7 +28,6 @@ const TaskDetailsInputOutput: React.FC<TaskDetailsInputOutputProps> = ({
         return {
           label: artifactInputOutput.label,
           value: <ArtifactUriLink uri={artifact.getUri()} />,
-          preview: <ArtifactPreview artifact={artifact} />,
         };
       }
 

diff --git a/...src/concepts/pipelines/content/pipelinesDetails/taskDetails/TaskDetailsPrintKeyValues.tsx b/...src/concepts/pipelines/content/pipelinesDetails/taskDetails/TaskDetailsPrintKeyValues.tsx
@@ -2,7 +2,7 @@ import * as React from 'react';
 import { Grid, GridItem, Truncate } from '@patternfly/react-core';
 
 type TaskDetailsPrintKeyValuesProps = {
-  items: { label: string; value: React.ReactNode; preview?: React.ReactNode }[];
+  items: { label: string; value: React.ReactNode }[];
 };
 
 const TaskDetailsPrintKeyValues: React.FC<TaskDetailsPrintKeyValuesProps> = ({ items }) => (
@@ -15,7 +15,6 @@ const TaskDetailsPrintKeyValues: React.FC<TaskDetailsPrintKeyValuesProps> = ({ i
           </b>
         </GridItem>
         <GridItem span={6}>{result.value}</GridItem>
-        {result.preview && <GridItem span={12}>{result.preview}</GridItem>}
       </React.Fragment>
     ))}
   </Grid>