Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.22.0 fixes logs parity #332

Merged
merged 4 commits into from
May 10, 2024
Merged

V2.22.0 fixes logs parity #332

merged 4 commits into from
May 10, 2024

Conversation

Gkrumbach07
Copy link

@Gkrumbach07 Gkrumbach07 commented May 10, 2024 •
edited
Loading

closes: https://issues.redhat.com/browse/RHOAIENG-6317

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Gkrumbach07 and others added 4 commits May 10, 2024 07:57
@Gkrumbach07
Update mlmd service proxy configuration port to 8443
72ae934 
Fix DEV_MODE import in mlmd service

Remove DEV_MODE import in mlmd service

Refactor mlmd service proxy configuration

Update mlmd service proxy configuration

Update mlmd service proxy configuration port to 10001
@openshift-merge-bot
Merge pull request #2801 from Gkrumbach07/mlmd-logs-fix
41e83ab 
Pipeline Pod logs 2.9.1 fix
@DaoDaoNoCode @Gkrumbach07
Read pipeline run node details from mlmd context
bd9bc95
@openshift-merge-bot
Merge pull request #2802 from Gkrumbach07/mlmd-logs-fix
65d72a9 
Read pipeline run node details from mlmd context
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Gkrumbach07 Gkrumbach07 changed the title V2.22.0 fixes V2.22.0 fixes logs parity May 10, 2024
@Gkrumbach07 Gkrumbach07 merged commit cd10efd into red-hat-data-services:rhoai-2.9 May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gkrumbach07 @andrewballantyne @DaoDaoNoCode