Skip to content

Commit

Permalink
update the install type to cli instead of CLi
Browse files Browse the repository at this point in the history
Signed-off-by: Kobi Hakimi <khakimi@redhat.com>
  • Loading branch information
kobihk committed Dec 25, 2024
1 parent 5906ead commit 912aa99
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion ods_ci/rhods_install_configuration.yaml.example
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
RHODS_INSTALL:
INSTALL_TYPE: CLi
INSTALL_TYPE: Cli
TEST_ENV: AWS
cluster_type: managed
operator_version: quay.io/modh/qe-catalog-source:latest
Expand Down
6 changes: 3 additions & 3 deletions ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Install RHODS
${csv_display_name} = Set Variable ${RHODS_CSV_DISPLAY}
END
IF "${cluster_type}" == "selfmanaged"
IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "CLi"
IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "Cli"
Install RHODS In Self Managed Cluster Using CLI ${cluster_type} ${image_url}
ELSE IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "OperatorHub"
${file_path} = Set Variable tasks/Resources/RHODS_OLM/install/
Expand All @@ -63,12 +63,12 @@ Install RHODS
FAIL Provided test environment and install type is not supported
END
ELSE IF "${cluster_type}" == "managed"
IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "CLi" and "${UPDATE_CHANNEL}" == "odh-nightlies"
IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "Cli" and "${UPDATE_CHANNEL}" == "odh-nightlies"

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning

Line is too long (124/120)
# odh-nightly is not build for Managed, it is only possible for Self-Managed
Set Global Variable ${OPERATOR_NAMESPACE} openshift-marketplace
Install RHODS In Self Managed Cluster Using CLI ${cluster_type} ${image_url}
Set Global Variable ${OPERATOR_NAME} opendatahub-operator
ELSE IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "CLi"
ELSE IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "Cli"
Install RHODS In Managed Cluster Using CLI ${cluster_type} ${image_url}
ELSE
FAIL Provided test environment is not supported
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Is RHODS Installed
Log Checking if RHODS is installed with "${clusterType}" "${UPDATE_CHANNEL}" "${INSTALL_TYPE}" console=yes
IF "${cluster_type}" == "selfmanaged"
IF "${INSTALL_TYPE}" == "CLi"
IF "${INSTALL_TYPE}" == "Cli"
${result}= Run Keyword And Return Status
... Run Keywords
... Check A RHODS Family Operator Is Installed namespace=${OPERATOR_NAMESPACE}
Expand Down
2 changes: 1 addition & 1 deletion ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Uninstall RHODS In OSD

Uninstall RHODS In Self Managed Cluster
[Documentation] Uninstall rhods from self-managed cluster
IF "${INSTALL_TYPE}" == "CLi"
IF "${INSTALL_TYPE}" == "Cli"
Uninstall RHODS In Self Managed Cluster Using CLI
ELSE IF "${INSTALL_TYPE}" == "OperatorHub"
Uninstall RHODS In Self Managed Cluster For Operatorhub
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ${SERVICE_MESH_OPERATOR_NS} openshift-operators
${SERVICE_MESH_OPERATOR_DEPLOYMENT_NAME} istio-operator
${SERVICE_MESH_CR_NS} istio-system
${SERVICE_MESH_CR_NAME} data-science-smcp
${INSTALL_TYPE} CLi
${INSTALL_TYPE} Cli

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${INSTALL_TYPE}' is assigned but not used
${TEST_ENV} PSI
${IS_PRESENT} 0
${IS_NOT_PRESENT} 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ${SERVICE_MESH_OPERATOR_DEPLOYMENT_NAME} istio-operator
${SERVICE_MESH_CR_NS} istio-system
${SERVICE_MESH_CR_NAME} data-science-smcp
${OLM_DIR} olm
${INSTALL_TYPE} CLi
${INSTALL_TYPE} Cli

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${INSTALL_TYPE}' is assigned but not used
${TEST_ENV} PSI
${IS_PRESENT} 0
${IS_NOT_PRESENT} 1
Expand Down

0 comments on commit 912aa99

Please sign in to comment.