[fix] the expected network policy content for the ODH execution #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
added
verified
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -275,7 +275,9 @@ | |||
| ${CR_name} = Get User CR Notebook Name username=${TEST_USER.USERNAME} | |||
| ${policy_ctrl} = Run | |||
| ... oc get networkpolicy ${CR_name}-ctrl-np -n ${NOTEBOOKS_NAMESPACE} -o json | jq '.spec.ingress[0]' | |||
| ${expected_policy_ctrl} = Get File ods_ci/tests/Resources/Files/expected_ctrl_np.txt | |||
| # ${expected_policy_ctrl} = Get File ods_ci/tests/Resources/Files/expected_ctrl_np.txt | |||
| ${rc} ${expected_policy_ctrl} = Run And Return Rc And Output | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used
ods_ci/tests/Tests/100__deploy/100__installation/102__post_install.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
jstourac
force-pushed
the
fixNetworkPolicyOdh
branch
from
7f93aa0 to
730c8f8
Compare
jiridanek
previously approved these changes
May 17, 2024
bdattoma
previously approved these changes
May 20, 2024
FedeAlonso
previously approved these changes
May 20, 2024
jstourac
dismissed stale reviews from FedeAlonso, bdattoma, and jiridanek
via
d2ef219
jstourac
force-pushed
the
fixNetworkPolicyOdh
branch
from
730c8f8 to
d2ef219
Compare
|
I'm sorry guys, I noticed I kept one unnecessary commented line in this PR. Thus I updated PR by deleting that line and also added ignore for the line length warning. Would be glad if you could review again. Thanks! |
bdattoma
approved these changes
May 20, 2024
This was failing with ODH because there is a different network policy content. I think that the content in ODH is as expected, as such, I have updated our test to match this difference and work properly on both ODH and RHOAI installations.
jiridanek
force-pushed
the
fixNetworkPolicyOdh
branch
from
d2ef219 to
4ad5314
Compare
jiridanek
approved these changes
May 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing with ODH because there is a different network policy content. I think that the content in ODH is as expected, as such, I have updated our test to match this difference and work properly on both ODH and RHOAI installations.
Tested both with ODH and RHOAI installation: