Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword to find ROSA_HCP environment #2143

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add keyword to find ROSA_HCP environment #2143

merged 1 commit into from
Jan 3, 2025

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Dec 24, 2024 •
edited
Loading

Add keyword to find ROSA_HCP environment

Closes RHOAIENG-17323

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 24, 2024
View reviewed changes
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0601__workloads_orchestration/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0601__workloads_orchestration/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0601__workloads_orchestration/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot Fixed Show fixed Hide fixed
@ChughShilpa
Copy link
Contributor Author

Smoke test passed on ROSA_HCP cluster in rhoai-test-flow/2176
and on other cluster in rhoai-test-flow/2175/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 24, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
589 0 0 589 100

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 26, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -256,3 +257,22 @@
[Documentation] Check that upstream Go test is not missing
[Arguments] ${test_run_output}
Should Not Contain ${test_run_output} testing: warning: no tests to run No Go tests were run

Verify container images

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Verify container images' does not follow case convention
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed
ods_ci/tests/Tests/0600__distributed_workloads/0601__workloads_orchestration/test-smoke.robot
Container Image Url Should Contain ${APPLICATIONS_NAMESPACE} ${pod} manager
... registry.redhat.io/rhoai/odh-kueue-controller
Log To Console kueue-controller-manager's container image is verified
Verify container images kueue-controller-manager manager odh-kueue-controller

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Verify container images' does not follow case convention
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot
Container Image Url Should Contain ${APPLICATIONS_NAMESPACE} ${pod} kuberay-operator
... registry.redhat.io/rhoai/odh-kuberay-operator-controller
Log To Console kuberay-operator's container image is verified
Verify container images kuberay-operator kuberay-operator odh-kuberay-operator-controller

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Verify container images' does not follow case convention
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot
Container Image Url Should Contain ${APPLICATIONS_NAMESPACE} ${pod} manager
... registry.redhat.io/rhoai/odh-codeflare-operator
Log To Console codeflare-operator-manager's container image is verified
Verify container images codeflare-operator-manager manager odh-codeflare-operator

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Verify container images' does not follow case convention
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-smoke.robot
Container Image Url Should Contain ${APPLICATIONS_NAMESPACE} ${pod} training-operator
... registry.redhat.io/rhoai/odh-training-operator
Log To Console kubeflow-training-operator's container image is verified
Verify container images kubeflow-training-operator training-operator odh-training-operator

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Verify container images' does not follow case convention
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 31, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
Verify container images
[Documentation] Verify container images
[Arguments] ${pod_name} ${container} ${expected_image}
${test_env}= Is Test Enviroment ROSA-HCP

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '=' instead
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
[Arguments] ${pod_name} ${container} ${expected_image}
${test_env}= Is Test Enviroment ROSA-HCP
# We use Kyverno custom policies to pull unreleased images from quay registry for hypershift clusters
${registry_name} = Set Variable If ${test_env}==True

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'Set Variable If' condition can be simplified
@ChughShilpa ChughShilpa requested a review from rnetser December 31, 2024 10:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ChughShilpa
Copy link
Contributor Author

ChughShilpa commented Jan 2, 2025 •
edited
Loading

@jgarciao Could you please review the PR

@ChughShilpa
Copy link
Contributor Author

@rnetser Addressed your requested changes, please review

@jgarciao jgarciao merged commit 0290749 into red-hat-data-services:master Jan 3, 2025
11 checks passed
@ChughShilpa ChughShilpa deleted the HCP branch January 3, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeet-dhumal abhijeet-dhumal abhijeet-dhumal approved these changes

@Srihari1192 Srihari1192 Srihari1192 approved these changes

@rnetser rnetser rnetser approved these changes

@sutaakar sutaakar sutaakar approved these changes

@jgarciao jgarciao jgarciao approved these changes

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChughShilpa @jgarciao @sutaakar @rnetser @Srihari1192 @abhijeet-dhumal