[2.16.0] update the install type to cli instead of CLi #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kobi Hakimi <khakimi@redhat.com>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -63,12 +63,12 @@ | |||
| FAIL Provided test environment and install type is not supported | |||
| END | |||
| ELSE IF "${cluster_type}" == "managed" | |||
| IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "CLi" and "${UPDATE_CHANNEL}" == "odh-nightlies" | |||
| IF "${TEST_ENV}" in "${SUPPORTED_TEST_ENV}" and "${INSTALL_TYPE}" == "Cli" and "${UPDATE_CHANNEL}" == "odh-nightlies" | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
| @@ -18,7 +18,7 @@ | |||
| ${SERVICE_MESH_OPERATOR_DEPLOYMENT_NAME} istio-operator | |||
| ${SERVICE_MESH_CR_NS} istio-system | |||
| ${SERVICE_MESH_CR_NAME} data-science-smcp | |||
| ${INSTALL_TYPE} CLi | |||
| ${INSTALL_TYPE} Cli | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| @@ -19,7 +19,7 @@ | |||
| ${SERVICE_MESH_CR_NS} istio-system | |||
| ${SERVICE_MESH_CR_NAME} data-science-smcp | |||
| ${OLM_DIR} olm | |||
| ${INSTALL_TYPE} CLi | |||
| ${INSTALL_TYPE} Cli | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
kobihk
changed the title
Robot Results
|
rnetser
approved these changes
Dec 26, 2024
manosnoam
approved these changes
Dec 26, 2024
kobihk
merged commit 2939582
into
red-hat-data-services:releases/2.16.0
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to use the Install/Uninstall type which currently is CLi in part of the code and Cli in another part of the code.
changing it from CLi to Cli everywhere.
related to Jira ticket: RHOAIENG-2720
cherry-picked #2144